Issue 1215613005: Improve the padding and sizing of popup menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1215613005: Improve the padding and sizing of popup menus. (Closed)

Created:
5 years, 5 months ago by Hixie

Modified:
5 years, 5 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Improve the padding and sizing of popup menus. Note that this wildly breaks the vertical alignment of menu items, I'll fix that in a subsequent CL. (It wasn't really working before either, but looked ok by pure luck.) R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ddca1c9d406533b10ce0581296a6ff64371cecc9

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -29 lines)			Patch
M	sky/sdk/lib/rendering/box.dart	View	2 chunks	+46 lines, -14 lines	1 comment	Download
M	sky/sdk/lib/widgets/basic.dart	View	1 chunk	+18 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/popup_menu.dart	View	3 chunks	+24 lines, -11 lines	0 comments	Download
M	sky/sdk/lib/widgets/popup_menu_item.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1215613005/diff/1/sky/sdk/lib/rendering/box.dart File sky/sdk/lib/rendering/box.dart (right): https://codereview.chromium.org/1215613005/diff/1/sky/sdk/lib/rendering/box.dart#newcode499 sky/sdk/lib/rendering/box.dart:499: stepHeight, Types? Also, I wonder if we can ...

5 years, 5 months ago (2015-06-30 20:51:44 UTC) #2

Hixie

5 years, 5 months ago (2015-06-30 20:56:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ddca1c9d406533b10ce0581296a6ff64371cecc9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages