sky/sdk/lib/widgets/popup_menu_item.dart - Issue 1215613005: Improve the padding and sizing of popup menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/widgets/popup_menu_item.dart

Issue 1215613005: Improve the padding and sizing of popup menus. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/widgets/popup_menu_item.dart

diff --git a/sky/sdk/lib/widgets/popup_menu_item.dart b/sky/sdk/lib/widgets/popup_menu_item.dart

index 42c0ce40ad602595fbd0c8623c87914ff8b626c5..17147cd10a8afccc2fa7c769e1744ac1b1e5c24b 100644

--- a/sky/sdk/lib/widgets/popup_menu_item.dart

+++ b/sky/sdk/lib/widgets/popup_menu_item.dart

@@ -21,8 +21,7 @@ class PopupMenuItem extends Component {

opacity: opacity,

child: new InkWell(

child: new Container(

- constraints: const BoxConstraints(minWidth: 112.0),

- padding: const EdgeDims.all(16.0),

+ height: 48.0,

child: new DefaultTextStyle(

style: textStyle,

child: child