Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1215593004: Revert of Reland [android] Migrate more configs to gyp. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland [android] Migrate more configs to gyp. (patchset #2 id:20001 of https://codereview.chromium.org/1210393003/) Reason for revert: [Sheriff] Fails runhooks. Original issue's description: > Reland [android] Migrate more configs to gyp. > > This reverts commit 3e8892b589f16454d4f592e2ed3f6d4ddf0a0bc6. > > BUG=chromium:502176 > LOG=n > NOTRY=true > TBR=ulan@chromium.org, jochen@chromium.org > > Committed: https://crrev.com/c0d70e43c4cbe2a09c8f1bd55fe2be03cd9ba041 > Cr-Commit-Position: refs/heads/master@{#29317} TBR=ulan@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:502176 Committed: https://crrev.com/e93e4dad632a019c6a863c7dd43491b607d6d096 Cr-Commit-Position: refs/heads/master@{#29319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -31 lines) Patch
M Makefile.android View 1 chunk +11 lines, -7 lines 0 comments Download
M build/standalone.gypi View 3 chunks +1 line, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Reland [android] Migrate more configs to gyp.
5 years, 6 months ago (2015-06-26 10:38:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215593004/1
5 years, 6 months ago (2015-06-26 10:39:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-26 10:39:12 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 10:39:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e93e4dad632a019c6a863c7dd43491b607d6d096
Cr-Commit-Position: refs/heads/master@{#29319}

Powered by Google App Engine
This is Rietveld 408576698