Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1210393003: Reland [android] Migrate more configs to gyp. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland [android] Migrate more configs to gyp. This reverts commit 3e8892b589f16454d4f592e2ed3f6d4ddf0a0bc6. BUG=chromium:502176 LOG=n NOTRY=true TBR=ulan@chromium.org, jochen@chromium.org Committed: https://crrev.com/c0d70e43c4cbe2a09c8f1bd55fe2be03cd9ba041 Cr-Commit-Position: refs/heads/master@{#29317}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M Makefile.android View 1 chunk +7 lines, -11 lines 0 comments Download
M build/standalone.gypi View 1 3 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210393003/20001
5 years, 5 months ago (2015-06-26 10:32:12 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-26 10:33:29 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c0d70e43c4cbe2a09c8f1bd55fe2be03cd9ba041 Cr-Commit-Position: refs/heads/master@{#29317}
5 years, 5 months ago (2015-06-26 10:33:43 UTC) #5
Michael Achenbach
5 years, 5 months ago (2015-06-26 10:38:50 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1215593004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Fails runhooks..

Powered by Google App Engine
This is Rietveld 408576698