Implement left property animation on InvalidatableStyleInterpolation

Implement left property animation on InvalidatableStyleInterpolation

This migrates animation of the left property to the InvalidatableStyleInterpolation
code path away from LengthStyleInterpolation.
This is a preliminary example of animation code in the new interpolation
design to be followed up by migrating the remaining length properties.

BUG=437696
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198915

[alancutter (OOO until 2018), 2015-06-26 03:28:02]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org, shans@chromium.org

[alancutter (OOO until 2018), 2015-06-26 03:28:03]

Posting this one out early, please provide high level feedback on the approach.
Still self reviewing the fine details in this patch.

[alancutter (OOO until 2018), 2015-06-30 04:52:10]

Rebased onto https://codereview.chromium.org/1210353004. This patch is ready for
review.

[shans, 2015-07-02 12:02:48]

Overall LGTM, would like Doug to take a look before commit.

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
File Source/core/animation/InterpolationType.h (right):

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
Source/core/animation/InterpolationType.h:52: bool operator!=(const
InterpolationType& other) const { return this != &other; }
A comment on these would be useful. At first glance they seem almost circular :)
maybe:
// Implement reference equality checking via pointer equality checking as these
are singletons

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
File Source/core/animation/LengthInterpolationType.cpp (right):

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
Source/core/animation/LengthInterpolationType.cpp:31:
listOfValuesAndTypes->set(1, listOfTypes.release());
listOfTypes can now be a NIV, and pairwise conversion can handle mismatches.

TODO?

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
Source/core/animation/LengthInterpolationType.cpp:152: return
InterpolationValue::create(*this, listOfValuesAndTypes.release());
This is very long, and seems to need to do a bunch of stuff that could at some
level be shared by multiple types (inherit / initial / neutral value handling).

[dstockwell, 2015-07-02 23:57:47]

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
File Source/core/animation/InvalidatableStyleInterpolation.cpp (right):

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
Source/core/animation/InvalidatableStyleInterpolation.cpp:117:
state.parentStyle()->setHasExplicitlyInheritedProperties();
Are you sure that parentStyle is never null here?

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
File Source/core/animation/LengthInterpolationType.cpp (right):

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
Source/core/animation/LengthInterpolationType.cpp:152: return
InterpolationValue::create(*this, listOfValuesAndTypes.release());
On 2015/07/02 at 12:02:48, shans wrote:
> This is very long, and seems to need to do a bunch of stuff that could at some
level be shared by multiple types (inherit / initial / neutral value handling).

+1

[alancutter (OOO until 2018), 2015-07-03 01:38:23]

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
File Source/core/animation/InterpolationType.h (right):

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
Source/core/animation/InterpolationType.h:52: bool operator!=(const
InterpolationType& other) const { return this != &other; }
On 2015/07/02 at 12:02:47, shans wrote:
> A comment on these would be useful. At first glance they seem almost circular
:)
> maybe:
> // Implement reference equality checking via pointer equality checking as
these are singletons

Done.

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
File Source/core/animation/InvalidatableStyleInterpolation.cpp (right):

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
Source/core/animation/InvalidatableStyleInterpolation.cpp:117:
state.parentStyle()->setHasExplicitlyInheritedProperties();
On 2015/07/02 at 23:57:46, dstockwell wrote:
> Are you sure that parentStyle is never null here?

Nope, added check.

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
File Source/core/animation/LengthInterpolationType.cpp (right):

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
Source/core/animation/LengthInterpolationType.cpp:31:
listOfValuesAndTypes->set(1, listOfTypes.release());
On 2015/07/02 at 12:02:47, shans wrote:
> listOfTypes can now be a NIV, and pairwise conversion can handle mismatches.
> 
> TODO?

Added TODO.

https://codereview.chromium.org/1215563002/diff/120001/Source/core/animation/...
Source/core/animation/LengthInterpolationType.cpp:152: return
InterpolationValue::create(*this, listOfValuesAndTypes.release());
On 2015/07/02 at 23:57:46, dstockwell wrote:
> On 2015/07/02 at 12:02:48, shans wrote:
> > This is very long, and seems to need to do a bunch of stuff that could at
some level be shared by multiple types (inherit / initial / neutral value
handling).
> 
> +1

Done.

[alancutter (OOO until 2018), 2015-07-13 08:07:48]

dstockwell: Ping.

[dstockwell, 2015-07-14 02:52:27]

lgtm

[alancutter (OOO until 2018), 2015-07-14 03:05:36]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2015-07-14 03:05:37]

The patchset sent to the CQ was uploaded after l-g-t-m from shans@chromium.org
Link to the patchset: https://codereview.chromium.org/1215563002/#ps200001
(title: "Dedupe code")

[commit-bot: I haz the power, 2015-07-14 03:05:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215563002/200001

[commit-bot: I haz the power, 2015-07-14 03:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-14 03:09:01]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[alancutter (OOO until 2018), 2015-07-14 06:50:32]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2015-07-14 06:50:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, shans@chromium.org
Link to the patchset: https://codereview.chromium.org/1215563002/#ps220001
(title: "Rebased")

[commit-bot: I haz the power, 2015-07-14 06:50:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215563002/220001

[commit-bot: I haz the power, 2015-07-14 08:09:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-14 08:09:12]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/70342)

[alancutter (OOO until 2018), 2015-07-15 01:55:13]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2015-07-15 01:55:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, shans@chromium.org
Link to the patchset: https://codereview.chromium.org/1215563002/#ps240001
(title: "Make Windows not crash")

[commit-bot: I haz the power, 2015-07-15 01:55:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215563002/240001

[commit-bot: I haz the power, 2015-07-15 03:51:48]

Committed patchset #13 (id:240001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198915