Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1215463012: Fixed a couple of proxies-related unhandled exceptions. (Closed)

Created:
5 years, 5 months ago by Igor Sheludko
Modified:
5 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixed a couple of proxies-related unhandled exceptions. BUG=chromium:506956, chromium:505907 LOG=N Committed: https://crrev.com/52b3e41799ef80cf47b84db15a3ade4f613a6ce1 Cr-Commit-Position: refs/heads/master@{#29530}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-scopes.cc View 1 4 chunks +14 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-505907.js View 1 chunk +5 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-506956.js View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Igor Sheludko
PTAL
5 years, 5 months ago (2015-07-07 10:33:22 UTC) #2
Yang
LGTM with comment. https://codereview.chromium.org/1215463012/diff/1/src/runtime/runtime-scopes.cc File src/runtime/runtime-scopes.cc (right): https://codereview.chromium.org/1215463012/diff/1/src/runtime/runtime-scopes.cc#newcode234 src/runtime/runtime-scopes.cc:234: if (isolate->has_pending_exception()) return isolate->heap()->exception(); This looks ...
5 years, 5 months ago (2015-07-08 07:55:18 UTC) #3
Igor Sheludko
Addressed comments
5 years, 5 months ago (2015-07-08 10:37:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215463012/20001
5 years, 5 months ago (2015-07-08 11:17:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-08 11:46:10 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 11:46:28 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/52b3e41799ef80cf47b84db15a3ade4f613a6ce1
Cr-Commit-Position: refs/heads/master@{#29530}

Powered by Google App Engine
This is Rietveld 408576698