src/objects.cc - Issue 1215463012: Fixed a couple of proxies-related unhandled exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1215463012: Fixed a couple of proxies-related unhandled exceptions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 24b54c0d4a3710160d5cde7b57d2bb9a732c2a86..a2220df152731341d093e11f71360f70259b02f6 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -4003,7 +4003,7 @@ Maybe<PropertyAttributes> JSProxy::GetPropertyAttributesWithHandler(

Handle<Object> error = isolate->factory()->NewTypeError(

MessageTemplate::kProxyPropNotConfigurable, handler, name, trap);

isolate->Throw(*error);

- return Just(NONE);

+ return Nothing<PropertyAttributes>();

}

int attributes = NONE;

« no previous file with comments | « no previous file | src/runtime/runtime-scopes.cc » ('j') | no next file with comments »