Move chrome://media-internals to content. This allows us to hide implementation details from the pu…

Move chrome://media-internals to content. This allows us to hide implementation details from the public API.

BUG=169170
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180040

[scherkus (not reviewing), 2013-02-01 02:05:17]

lgtm w/ nits

awesome stuff!

https://codereview.chromium.org/12153002/diff/7008/chrome/browser/extensions/...
File chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc (right):

https://codereview.chromium.org/12153002/diff/7008/chrome/browser/extensions/...
chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc:143: default:
nit: while you're here can you replace the default handler w/ the two missing
enum states from content/public/browser/media_request_state.h ?

MEDIA_REQUEST_STATE_NOT_REQUESTED
MEDIA_REQUEST_STATE_OPENING

I'm a big fan of having the compiler break if you add/remove enums

https://codereview.chromium.org/12153002/diff/7008/chrome/browser/extensions/...
File chrome/browser/extensions/api/tab_capture/tab_capture_registry.h (right):

https://codereview.chromium.org/12153002/diff/7008/chrome/browser/extensions/...
chrome/browser/extensions/api/tab_capture/tab_capture_registry.h:62: //
MediaCaptureDevicesDispatcher::Observer implementation:
consistency nit: line 57 uses ".", this line uses ":"

https://codereview.chromium.org/12153002/diff/7008/content/browser/renderer_h...
File content/browser/renderer_host/media/mock_media_observer.h (right):

https://codereview.chromium.org/12153002/diff/7008/content/browser/renderer_h...
content/browser/renderer_host/media/mock_media_observer.h:39: class
MockMediaInternals : public MediaInternals {
hmmmm I wonder how useful these mocks object are...something for me to think
about some day

https://codereview.chromium.org/12153002/diff/7008/content/public/browser/med...
File content/public/browser/media_observer.h (left):

https://codereview.chromium.org/12153002/diff/7008/content/public/browser/med...
content/public/browser/media_observer.h:22: virtual void
OnDeleteAudioStream(void* host, int stream_id) = 0;
AWESOME!

https://codereview.chromium.org/12153002/diff/7008/content/test/webrtc_audio_...
File content/test/webrtc_audio_device_test.cc (right):

https://codereview.chromium.org/12153002/diff/7008/content/test/webrtc_audio_...
content/test/webrtc_audio_device_test.cc:209: media_internals_.reset(new
MockMediaInternals());
I should ping the folks of this test -- I don't see any expectations set on this
so I'm a bit confused what we're mocking here as opposed to using the real class

[jam, 2013-02-01 02:18:21]

https://codereview.chromium.org/12153002/diff/7008/chrome/browser/extensions/...
File chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc (right):

https://codereview.chromium.org/12153002/diff/7008/chrome/browser/extensions/...
chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc:143: default:
On 2013/02/01 02:05:17, scherkus wrote:
> nit: while you're here can you replace the default handler w/ the two missing
> enum states from content/public/browser/media_request_state.h ?
> 
> MEDIA_REQUEST_STATE_NOT_REQUESTED
> MEDIA_REQUEST_STATE_OPENING
> 
> I'm a big fan of having the compiler break if you add/remove enums

These don't have equivalent values int the tab_capture::TabCaptureState enum.
It's not clear to me as someone not familiar with this code what I'd have to do
if I update that idl file, so I'd rather not fix this now

https://codereview.chromium.org/12153002/diff/7008/chrome/browser/extensions/...
File chrome/browser/extensions/api/tab_capture/tab_capture_registry.h (right):

https://codereview.chromium.org/12153002/diff/7008/chrome/browser/extensions/...
chrome/browser/extensions/api/tab_capture/tab_capture_registry.h:62: //
MediaCaptureDevicesDispatcher::Observer implementation:
On 2013/02/01 02:05:17, scherkus wrote:
> consistency nit: line 57 uses ".", this line uses ":"

Done.

https://codereview.chromium.org/12153002/diff/7008/content/browser/renderer_h...
File content/browser/renderer_host/media/mock_media_observer.h (right):

https://codereview.chromium.org/12153002/diff/7008/content/browser/renderer_h...
content/browser/renderer_host/media/mock_media_observer.h:39: class
MockMediaInternals : public MediaInternals {
On 2013/02/01 02:05:17, scherkus wrote:
> hmmmm I wonder how useful these mocks object are...something for me to think
> about some day

i strongly dislike gmock :)