Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2865)

Unified Diff: chrome/browser/media/media_internals_unittest.cc

Issue 12153002: Move chrome://media-internals to content. This allows us to hide implementation details from the pu… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/media_internals_unittest.cc
===================================================================
--- chrome/browser/media/media_internals_unittest.cc (revision 179909)
+++ chrome/browser/media/media_internals_unittest.cc (working copy)
@@ -1,114 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/media/media_internals.h"
-
-#include "base/memory/scoped_ptr.h"
-#include "base/message_loop.h"
-#include "chrome/browser/media/media_internals_observer.h"
-#include "content/public/test/test_browser_thread.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-class MockMediaInternalsObserver : public MediaInternalsObserver {
- public:
- MOCK_METHOD1(OnUpdate, void(const string16& javascript));
-};
-
-class MediaInternalsTest : public testing::Test {
- public:
- MediaInternalsTest() : io_thread_(content::BrowserThread::IO, &loop_) {}
- DictionaryValue* data() {
- return &internals_->data_;
- }
-
- void DeleteItem(const std::string& item) {
- internals_->DeleteItem(item);
- }
-
- void UpdateItem(const std::string& item, const std::string& property,
- Value* value) {
- internals_->UpdateItem("", item, property, value);
- }
-
- void SendUpdate(const std::string& function, Value* value) {
- internals_->SendUpdate(function, value);
- }
-
- protected:
- virtual void SetUp() {
- internals_.reset(new MediaInternals());
- }
-
- MessageLoop loop_;
- content::TestBrowserThread io_thread_;
- scoped_ptr<MediaInternals> internals_;
-};
-
-TEST_F(MediaInternalsTest, UpdateAddsNewItem) {
- UpdateItem("some.item", "testing", Value::CreateBooleanValue(true));
- bool testing = false;
- std::string id;
-
- EXPECT_TRUE(data()->GetBoolean("some.item.testing", &testing));
- EXPECT_TRUE(testing);
-
- EXPECT_TRUE(data()->GetString("some.item.id", &id));
- EXPECT_EQ(id, "some.item");
-}
-
-TEST_F(MediaInternalsTest, UpdateModifiesExistingItem) {
- UpdateItem("some.item", "testing", Value::CreateBooleanValue(true));
- UpdateItem("some.item", "value", Value::CreateIntegerValue(5));
- UpdateItem("some.item", "testing", Value::CreateBooleanValue(false));
- bool testing = true;
- int value = 0;
- std::string id;
-
- EXPECT_TRUE(data()->GetBoolean("some.item.testing", &testing));
- EXPECT_FALSE(testing);
-
- EXPECT_TRUE(data()->GetInteger("some.item.value", &value));
- EXPECT_EQ(value, 5);
-
- EXPECT_TRUE(data()->GetString("some.item.id", &id));
- EXPECT_EQ(id, "some.item");
-}
-
-TEST_F(MediaInternalsTest, ObserversReceiveNotifications) {
- scoped_ptr<MockMediaInternalsObserver> observer(
- new MockMediaInternalsObserver());
-
- EXPECT_CALL(*observer.get(), OnUpdate(testing::_)).Times(1);
-
- internals_->AddObserver(observer.get());
- SendUpdate("fn", data());
-}
-
-TEST_F(MediaInternalsTest, RemovedObserversReceiveNoNotifications) {
- scoped_ptr<MockMediaInternalsObserver> observer(
- new MockMediaInternalsObserver());
-
- EXPECT_CALL(*observer.get(), OnUpdate(testing::_)).Times(0);
-
- internals_->AddObserver(observer.get());
- internals_->RemoveObserver(observer.get());
- SendUpdate("fn", data());
-}
-
-TEST_F(MediaInternalsTest, DeleteRemovesItem) {
- Value* out;
-
- UpdateItem("some.item", "testing", Value::CreateNullValue());
- EXPECT_TRUE(data()->Get("some.item", &out));
- EXPECT_TRUE(data()->Get("some", &out));
-
- DeleteItem("some.item");
- EXPECT_FALSE(data()->Get("some.item", &out));
- EXPECT_TRUE(data()->Get("some", &out));
-
- DeleteItem("some");
- EXPECT_FALSE(data()->Get("some.item", &out));
- EXPECT_FALSE(data()->Get("some", &out));
-}

Powered by Google App Engine
This is Rietveld 408576698