Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1215103003: Register array buffer right after writing it into the object (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Register array buffer right after writing it into the object BUG=chromium:504875 R=hpayer@chromium.org LOG=n Committed: https://crrev.com/e60ce8d1468d781b2b4aec19d76090299d196ae8 Cr-Commit-Position: refs/heads/master@{#29377}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/runtime/runtime-typedarray.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-06-30 10:09:08 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/1215103003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1215103003/diff/1/src/heap/heap.cc#newcode1841 src/heap/heap.cc:1841: buffer != not_yet_discovered_buffers.end(); ++buffer) { Let's remove the printf ...
5 years, 5 months ago (2015-06-30 12:08:37 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 5 months ago (2015-06-30 12:20:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215103003/20001
5 years, 5 months ago (2015-06-30 12:21:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-30 12:40:44 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 12:41:04 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e60ce8d1468d781b2b4aec19d76090299d196ae8
Cr-Commit-Position: refs/heads/master@{#29377}

Powered by Google App Engine
This is Rietveld 408576698