Register array buffer right after writing it into the object

src/heap/heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/accessors.h"
 #include "src/api.h"
 #include "src/base/bits.h"
 #include "src/base/once.h"
@@ skipping 1820 matching lines @@
     std::map<void*, size_t>& not_yet_discovered_buffers, void* data) {
   not_yet_discovered_buffers.erase(data);
 }
 
 
 size_t Heap::FreeDeadArrayBuffersHelper(
     Isolate* isolate, std::map<void*, size_t>& live_buffers,
     std::map<void*, size_t>& not_yet_discovered_buffers) {
   size_t freed_memory = 0;
   for (auto buffer = not_yet_discovered_buffers.begin();
        buffer != not_yet_discovered_buffers.end(); ++buffer) {

[Hannes Payer (out of office), 2015/06/30 12:08:37]

Let's remove the printf debugging :)

+    fprintf(stderr, "free buffer %p\n", buffer->first);
     isolate->array_buffer_allocator()->Free(buffer->first, buffer->second);
     freed_memory += buffer->second;
     live_buffers.erase(buffer->first);
   }
   not_yet_discovered_buffers = live_buffers;
   return freed_memory;
 }
 
 
 void Heap::TearDownArrayBuffersHelper(
     Isolate* isolate, std::map<void*, size_t>& live_buffers,
     std::map<void*, size_t>& not_yet_discovered_buffers) {
   for (auto buffer = live_buffers.begin(); buffer != live_buffers.end();
        ++buffer) {
     isolate->array_buffer_allocator()->Free(buffer->first, buffer->second);
   }
   live_buffers.clear();
   not_yet_discovered_buffers.clear();
 }
 
 
 void Heap::RegisterNewArrayBuffer(bool in_new_space, void* data,
                                   size_t length) {
   if (!data) return;
+  fprintf(stderr, "new buffer %p (%s space)\n", data,
+          in_new_space ? "new" : "old");
   RegisterNewArrayBufferHelper(live_array_buffers_, data, length);
   if (in_new_space) {
     RegisterNewArrayBufferHelper(live_array_buffers_for_scavenge_, data,
                                  length);
   }
   reinterpret_cast<v8::Isolate*>(isolate_)
       ->AdjustAmountOfExternalAllocatedMemory(length);
 }
 
 
 void Heap::UnregisterArrayBuffer(bool in_new_space, void* data) {
   if (!data) return;
+  fprintf(stderr, "unreg buffer %p (%s space)\n", data,
+          in_new_space ? "new" : "old");
   UnregisterArrayBufferHelper(live_array_buffers_,
                               not_yet_discovered_array_buffers_, data);
   if (in_new_space) {
     UnregisterArrayBufferHelper(live_array_buffers_for_scavenge_,
                                 not_yet_discovered_array_buffers_for_scavenge_,
                                 data);
   }
 }
 
 
 void Heap::RegisterLiveArrayBuffer(bool from_scavenge, void* data) {
   // ArrayBuffer might be in the middle of being constructed.
   if (data == undefined_value()) return;
+  fprintf(stderr, "found buffer %p (%s space)\n", data,
+          from_scavenge ? "new" : "old");
   RegisterLiveArrayBufferHelper(
       from_scavenge ? not_yet_discovered_array_buffers_for_scavenge_
                     : not_yet_discovered_array_buffers_,
       data);
 }
 
 
 void Heap::FreeDeadArrayBuffers(bool from_scavenge) {
+  fprintf(stderr, "reaping buffers in %s space:\n",
+          from_scavenge ? "new" : "old");
   if (from_scavenge) {
     for (auto& buffer : not_yet_discovered_array_buffers_for_scavenge_) {
       not_yet_discovered_array_buffers_.erase(buffer.first);
       live_array_buffers_.erase(buffer.first);
     }
   } else {
     for (auto& buffer : not_yet_discovered_array_buffers_) {
       // Scavenge can't happend during evacuation, so we only need to update
       // live_array_buffers_for_scavenge_.
       // not_yet_discovered_array_buffers_for_scanvenge_ will be reset before
@@ skipping 14 matching lines @@
 }
 
 
 void Heap::TearDownArrayBuffers() {
   TearDownArrayBuffersHelper(isolate_, live_array_buffers_,
                              not_yet_discovered_array_buffers_);
 }
 
 
 void Heap::PrepareArrayBufferDiscoveryInNewSpace() {
+  fprintf(stderr, "prepare scavenge\n");
   not_yet_discovered_array_buffers_for_scavenge_ =
       live_array_buffers_for_scavenge_;
 }
 
 
 void Heap::PromoteArrayBuffer(Object* obj) {
   JSArrayBuffer* buffer = JSArrayBuffer::cast(obj);
   if (buffer->is_external()) return;
   void* data = buffer->backing_store();
   if (!data) return;
   // ArrayBuffer might be in the middle of being constructed.
   if (data == undefined_value()) return;
+  fprintf(stderr, "promoting buffer %p\n", data);
   DCHECK(live_array_buffers_for_scavenge_.count(data) > 0);
   DCHECK(live_array_buffers_.count(data) > 0);
   live_array_buffers_for_scavenge_.erase(data);
   not_yet_discovered_array_buffers_for_scavenge_.erase(data);
 }
 
 
 void Heap::ProcessAllocationSites(WeakObjectRetainer* retainer) {
   Object* allocation_site_obj =
       VisitWeakList<AllocationSite>(this, allocation_sites_list(), retainer);
@@ skipping 4893 matching lines @@
     *object_type = "CODE_TYPE";                                                \
     *object_sub_type = "CODE_AGE/" #name;                                      \
     return true;
     CODE_AGE_LIST_COMPLETE(COMPARE_AND_RETURN_NAME)
 #undef COMPARE_AND_RETURN_NAME
   }
   return false;
 }
 }  // namespace internal
 }  // namespace v8