ui/gfx/skbitmap_operations_unittest.cc - Issue 12151002: Initialize memory, remove valgrind supression, add transparency test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/skbitmap_operations_unittest.cc

Issue 12151002: Initialize memory, remove valgrind supression, add transparency test. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/skbitmap_operations_unittest.cc

diff --git a/ui/gfx/skbitmap_operations_unittest.cc b/ui/gfx/skbitmap_operations_unittest.cc

index c6d0bd16a8ef8b1271e063954b103418eee29bc3..bfb2e1f88da524913994a1569ba5829c65e32f94 100644

--- a/ui/gfx/skbitmap_operations_unittest.cc

+++ b/ui/gfx/skbitmap_operations_unittest.cc

@@ -534,11 +534,12 @@ TEST(SkBitmapOperationsTest, RotateImage) {

src.allocPixels();

oshima 2013/01/31 23:34:25 I think src.eraseARGB(0, 0, 0, 0); is what you n

SkCanvas canvas(src);

+ canvas.clear(SkColorSetARGB(0, 0, 0, 0));

SkRegion region;

region.setRect(0, 0, src_w / 2, src_h / 2);

canvas.setClipRegion(region);

- canvas.drawColor(SK_ColorRED, SkXfermode::kSrc_Mode);

+ canvas.drawColor(0x1FFF0000, SkXfermode::kSrc_Mode);

oshima 2013/01/31 23:34:25 is this intentional?

region.setRect(src_w / 2, 0, src_w, src_h / 2);

canvas.setClipRegion(region);

canvas.drawColor(SK_ColorBLUE, SkXfermode::kSrc_Mode);

« no previous file with comments | « tools/valgrind/memcheck/suppressions.txt ('k') | no next file » | no next file with comments »