Initialize memory, remove valgrind supression, add transparency test.

ui/gfx/skbitmap_operations_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/skbitmap_operations.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "third_party/skia/include/core/SkColorPriv.h"
@@ skipping 513 matching lines @@
 // Check that Rotate provides the desired results
 TEST(SkBitmapOperationsTest, RotateImage) {
   const int src_w = 6, src_h = 4;
   SkBitmap src;
   // Create a simple 4 color bitmap:
   // RRRBBB
   // RRRBBB
   // GGGYYY
   // GGGYYY
   src.setConfig(SkBitmap::kARGB_8888_Config, src_w, src_h);
   src.allocPixels();

[oshima, 2013/01/31 23:34:25]

I think

src.eraseARGB(0, 0, 0, 0);

is what you need. 

 
   SkCanvas canvas(src);
+  canvas.clear(SkColorSetARGB(0, 0, 0, 0));
   SkRegion region;
 
   region.setRect(0, 0, src_w / 2, src_h / 2);
   canvas.setClipRegion(region);
-  canvas.drawColor(SK_ColorRED, SkXfermode::kSrc_Mode);
+  canvas.drawColor(0x1FFF0000, SkXfermode::kSrc_Mode);

[oshima, 2013/01/31 23:34:25]

is this intentional?

   region.setRect(src_w / 2, 0, src_w, src_h / 2);
   canvas.setClipRegion(region);
   canvas.drawColor(SK_ColorBLUE, SkXfermode::kSrc_Mode);
   region.setRect(0, src_h / 2, src_w / 2, src_h);
   canvas.setClipRegion(region);
   canvas.drawColor(SK_ColorGREEN, SkXfermode::kSrc_Mode);
   region.setRect(src_w / 2, src_h / 2, src_w, src_h);
   canvas.setClipRegion(region);
   canvas.drawColor(SK_ColorYELLOW, SkXfermode::kSrc_Mode);
   canvas.flush();
@@ skipping 20 matching lines @@
 
   for (int x=0; x < src_w; ++x) {
     for (int y=0; y < src_h; ++y) {
       ASSERT_EQ(*src.getAddr32(x,y), *rotate90.getAddr32(y, src_w - (x+1)));
       ASSERT_EQ(*src.getAddr32(x,y), *rotate270.getAddr32(src_h - (y+1),x));
       ASSERT_EQ(*src.getAddr32(x,y),
                 *rotate180.getAddr32(src_w - (x+1), src_h - (y+1)));
     }
   }
 }