Issue 1215093002: Clean up the IDL compiler around [SetWrapperReferenceFrom/To]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1215093002: Clean up the IDL compiler around [SetWrapperReferenceFrom/To] (Closed)

Created:
5 years, 5 months ago by haraken

Modified:
5 years, 5 months ago

Reviewers:
bashi, Yuki

CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Clean up the IDL compiler around [SetWrapperReferenceFrom/To] - Rename node_reachable_function to set_wrapper_reference_from. - Drop support for [SetWrapperReferenceTo=(...)] that takes more than one argument. There is no use case at the moment. - No change in the generated code. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198038

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -25 lines)			Patch
M	Source/bindings/scripts/idl_definitions.py	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	Source/bindings/scripts/v8_interface.py	View	2 chunks	+18 lines, -17 lines	0 comments	Download
M	Source/bindings/templates/interface.cpp	View	1 chunk	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215093002/1

5 years, 5 months ago (2015-06-30 05:53:09 UTC) #6

commit-bot: I haz the power

5 years, 5 months ago (2015-06-30 06:37:08 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198038

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages