Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: Source/bindings/templates/interface.cpp

Issue 1215093002: Clean up the IDL compiler around [SetWrapperReferenceFrom/To] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index 4059005269323210e0aae28bc8300c47630e1598..aa761eb9006cb5cfa391c333d2b75b337d4a8302 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -546,25 +546,23 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
{##############################################################################}
{% block visit_dom_wrapper %}
-{% if reachable_node_function or set_wrapper_reference_to_list %}
+{% if set_wrapper_reference_from or set_wrapper_reference_to %}
void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* scriptWrappable, const v8::Persistent<v8::Object>& wrapper)
{
{{cpp_class}}* impl = scriptWrappable->toImpl<{{cpp_class}}>();
- {% if set_wrapper_reference_to_list %}
+ {% if set_wrapper_reference_to %}
v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper);
V8WrapperInstantiationScope scope(creationContext, isolate);
- {% for set_wrapper_reference_to in set_wrapper_reference_to_list %}
{{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = impl->{{set_wrapper_reference_to.name}}();
if ({{set_wrapper_reference_to.name}}) {
if (!DOMDataStore::containsWrapper({{set_wrapper_reference_to.name}}, isolate))
{{set_wrapper_reference_to.name}}->wrap(isolate, creationContext);
DOMDataStore::setWrapperReference(wrapper, {{set_wrapper_reference_to.name}}, isolate);
}
- {% endfor %}
{% endif %}
- {% if reachable_node_function %}
- // The {{reachable_node_function}}() method may return a reference or a pointer.
- if (Node* owner = WTF::getPtr(impl->{{reachable_node_function}}())) {
+ {% if set_wrapper_reference_from %}
+ // The {{set_wrapper_reference_from}}() method may return a reference or a pointer.
+ if (Node* owner = WTF::getPtr(impl->{{set_wrapper_reference_from}}())) {
Node* root = V8GCController::opaqueRootForGC(isolate, owner);
isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(root)), wrapper);
return;
« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698