Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1215033002: Add benchmarkstream to visualbench (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@microbenches
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add benchmarkstream to visualbench BUG=skia: Committed: https://skia.googlesource.com/skia/+/962cc98eb49c5bb9b8c8382e7709e6f4b32ebce0

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweaks #

Total comments: 2

Patch Set 4 : tweaks #

Patch Set 5 : tweaks #

Patch Set 6 : tweaks #

Patch Set 7 : more #

Patch Set 8 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -59 lines) Patch
M bench/Benchmark.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M gyp/visualbench.gyp View 1 2 3 4 5 6 1 chunk +19 lines, -1 line 0 comments Download
M tools/VisualBench/VisualBench.h View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M tools/VisualBench/VisualBench.cpp View 7 chunks +28 lines, -53 lines 0 comments Download
A tools/VisualBench/VisualBenchmarkStream.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A tools/VisualBench/VisualBenchmarkStream.cpp View 1 2 3 4 1 chunk +103 lines, -0 lines 0 comments Download
A tools/VisualBench/VisualSKPBench.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A tools/VisualBench/VisualSKPBench.cpp View 1 2 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 5 months ago (2015-06-29 20:39:09 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1215033002/diff/40001/bench/Benchmark.h File bench/Benchmark.h (right): https://codereview.chromium.org/1215033002/diff/40001/bench/Benchmark.h#newcode105 bench/Benchmark.h:105: virtual bool isVisual() { return false; } comment? ...
5 years, 5 months ago (2015-06-29 21:04:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215033002/90009
5 years, 5 months ago (2015-06-30 14:36:23 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 14:43:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #8 (id:90009) as
https://skia.googlesource.com/skia/+/962cc98eb49c5bb9b8c8382e7709e6f4b32ebce0

Powered by Google App Engine
This is Rietveld 408576698