chrome/browser/safe_json_parser_browsertest.cc - Issue 1214903010: Make JSONParser a pure interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_json_parser_browsertest.cc

Issue 1214903010: Make JSONParser a pure interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_json_parser_browsertest.cc

diff --git a/chrome/browser/safe_json_parser_browsertest.cc b/chrome/browser/safe_json_parser_browsertest.cc

index 119ecbc87c7e498c723631ed04b59d5d35dc02e9..acbbad10fb3f7920d046c9442326d534334715ac 100644

--- a/chrome/browser/safe_json_parser_browsertest.cc

+++ b/chrome/browser/safe_json_parser_browsertest.cc

@@ -54,9 +54,7 @@ class SafeJsonParserTest : public InProcessBrowserTest {

error_callback = base::Bind(&SafeJsonParserTest::ExpectError,

base::Unretained(this), error);

}

- scoped_refptr<SafeJsonParser> parser =

- new SafeJsonParser(json, success_callback, error_callback);

- parser->Start();

+ SafeJsonParser::Parse(json, success_callback, error_callback);

message_loop_runner_->Run();

message_loop_runner_ = nullptr;