chrome/browser/extensions/webstore_install_helper.h - Issue 1214903010: Make JSONParser a pure interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_install_helper.h

Issue 1214903010: Make JSONParser a pure interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_install_helper.h

diff --git a/chrome/browser/extensions/webstore_install_helper.h b/chrome/browser/extensions/webstore_install_helper.h

index 90c6b65a9d7daa4346c03306bf3b67abb097e073..0defa243893cef3f51126229a798512d9a4d9a6d 100644

--- a/chrome/browser/extensions/webstore_install_helper.h

+++ b/chrome/browser/extensions/webstore_install_helper.h

@@ -96,7 +96,7 @@ class WebstoreInstallHelper : public base::RefCounted<WebstoreInstallHelper>,

// The manifest to parse.

std::string manifest_;

- scoped_refptr<safe_json::SafeJsonParser> json_parser_;

+ bool started_;

Robert Sesek 2015/07/02 17:28:19 Needs a comment (and maybe a more descriptive name

Bernhard Bauer 2015/07/02 22:38:23 Y'know, we can probably remove it. It was only the

// If |icon_url_| is non-empty, it needs to be fetched and decoded into an

// SkBitmap.