Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214903008: Revert of Use page_set_module.PageSet instead of story.StorySet (Closed)

Created:
5 years, 5 months ago by rmistry
Modified:
5 years, 5 months ago
Reviewers:
nednguyen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Use page_set_module.PageSet instead of story.StorySet (patchset #1 id:1 of https://codereview.chromium.org/1221553003/) Reason for revert: This should no longer be required due to Ned's fix in https://codereview.chromium.org/1217823005/ Original issue's description: > Use page_set_module.PageSet instead of story.StorySet > > BUG=skia:3967 > NOTRY=true > TBR=nednguyen > > Committed: https://skia.googlesource.com/skia/+/7b971f0152299ae9a924252a9bfd220318497bdd TBR=nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3967 Committed: https://skia.googlesource.com/skia/+/8f74c160c31b11155300f0a7b79cb8906775c185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M tools/skp/page_sets/skia_carsvg_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_chalkboard_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_css3gradients_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_digg_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_espn_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gamedeksiam_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gmail_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_gmailthread_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_googlehome_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_googlespreadsheet_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_jsfiddlebigcar_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_mapsvg_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_mozilla_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_nytimes_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_pokemonwiki_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_pravda_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_samoasvg_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_theverge_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_tigersvg_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_ugamsolutions_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_unicodetable_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_wikipedia_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_worldjournal_nexus10.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skp/page_sets/skia_wowwiki_desktop.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
Created Revert of Use page_set_module.PageSet instead of story.StorySet
5 years, 5 months ago (2015-06-30 15:22:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214903008/1
5 years, 5 months ago (2015-06-30 15:22:14 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 15:22:28 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8f74c160c31b11155300f0a7b79cb8906775c185

Powered by Google App Engine
This is Rietveld 408576698