Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1214903006: Binding: Remove unnecessary setObjectGroupId from visitDOMWrapper (Closed)

Created:
5 years, 5 months ago by haraken
Modified:
5 years, 5 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Binding: Remove unnecessary setObjectGroupId from visitDOMWrapper I believe the setObjectGroupId is unnecessary. - Regarding [SetWrapperReferenceTo], it shouldn't be necessary because [SetWrapperReferenceTo] doesn't create any object group id. - Regarding [SetWrapperReferenceFrom], setObjectGroupId is called only when the C++ reachable function returns null (e.g., NodeList::owner() returns null). In this case, it shouldn't be necessary to create an object id for the NodeList. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/bindings/templates/interface.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
haraken
PTAL. Bots looks happy.
5 years, 5 months ago (2015-06-30 05:58:11 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-06-30 08:16:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214903006/1
5 years, 5 months ago (2015-06-30 08:16:20 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 09:10:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198043

Powered by Google App Engine
This is Rietveld 408576698