Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 1214903006: Binding: Remove unnecessary setObjectGroupId from visitDOMWrapper (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 552 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 {% endfor %} 563 {% endfor %}
564 {% endif %} 564 {% endif %}
565 {% if reachable_node_function %} 565 {% if reachable_node_function %}
566 // The {{reachable_node_function}}() method may return a reference or a poin ter. 566 // The {{reachable_node_function}}() method may return a reference or a poin ter.
567 if (Node* owner = WTF::getPtr(impl->{{reachable_node_function}}())) { 567 if (Node* owner = WTF::getPtr(impl->{{reachable_node_function}}())) {
568 Node* root = V8GCController::opaqueRootForGC(isolate, owner); 568 Node* root = V8GCController::opaqueRootForGC(isolate, owner);
569 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper); 569 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper);
570 return; 570 return;
571 } 571 }
572 {% endif %} 572 {% endif %}
573 setObjectGroup(isolate, scriptWrappable, wrapper);
574 } 573 }
575 574
576 {% endif %} 575 {% endif %}
577 {% endblock %} 576 {% endblock %}
578 577
579 578
580 {##############################################################################} 579 {##############################################################################}
581 {% block shadow_attributes %} 580 {% block shadow_attributes %}
582 {% from 'attributes.cpp' import attribute_configuration with context %} 581 {% from 'attributes.cpp' import attribute_configuration with context %}
583 {% if interface_name == 'Window' %} 582 {% if interface_name == 'Window' %}
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
943 } 942 }
944 943
945 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 944 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
946 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 945 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
947 { 946 {
948 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 947 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
949 } 948 }
950 {% endfor %} 949 {% endfor %}
951 {% endif %} 950 {% endif %}
952 {% endblock %} 951 {% endblock %}
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698