Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: Source/core/inspector/V8Debugger.h

Issue 1214863013: [DevTools] Remove ScriptDebugListener from V8Debugger. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/ScriptDebuggerBase.cpp ('k') | Source/core/inspector/V8Debugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/V8Debugger.h
diff --git a/Source/core/inspector/V8Debugger.h b/Source/core/inspector/V8Debugger.h
index 5e35c7e17ec377fc38e6d7831757ec0e75ac2a43..c615e9fd3868ef8b4f984b29870bc4d82838f2b0 100644
--- a/Source/core/inspector/V8Debugger.h
+++ b/Source/core/inspector/V8Debugger.h
@@ -43,7 +43,6 @@
namespace blink {
class ScriptState;
-class ScriptDebugListener;
class ScriptValue;
class JavaScriptCallFrame;
@@ -119,9 +118,14 @@ public:
public:
virtual ~Client() { }
virtual v8::Local<v8::Object> compileDebuggerScript() = 0;
- virtual ScriptDebugListener* getDebugListenerForContext(v8::Local<v8::Context>) = 0;
virtual void runMessageLoopOnPause(v8::Local<v8::Context>) = 0;
virtual void quitMessageLoopOnPause() = 0;
+ virtual void didParseSource(v8::Local<v8::Context>, const ParsedScript&) = 0;
+ virtual SkipPauseRequest didPause(ScriptState*, const ScriptValue& callFrames, const ScriptValue& exception, const Vector<String>& hitBreakpoints, bool isPromiseRejection) = 0;
+ virtual bool v8AsyncTaskEventsEnabled(ScriptState*) = 0;
+ virtual void didReceiveV8AsyncTaskEvent(ScriptState*, const String& eventType, const String& eventName, int id) = 0;
+ virtual bool v8PromiseEventsEnabled(ScriptState*) = 0;
+ virtual void didReceiveV8PromiseEvent(ScriptState*, v8::Local<v8::Object> promise, v8::Local<v8::Value> parentPromise, int status) = 0;
DEFINE_INLINE_VIRTUAL_TRACE() { }
};
@@ -209,8 +213,8 @@ private:
};
ScriptValue currentCallFramesInner(ScopeInfoDetails);
PassRefPtr<JavaScriptCallFrame> wrapCallFrames(int maximumLimit, ScopeInfoDetails);
- void handleV8AsyncTaskEvent(ScriptDebugListener*, ScriptState* pausedScriptState, v8::Local<v8::Object> executionState, v8::Local<v8::Object> eventData);
- void handleV8PromiseEvent(ScriptDebugListener*, ScriptState* pausedScriptState, v8::Local<v8::Object> executionState, v8::Local<v8::Object> eventData);
+ void handleV8AsyncTaskEvent(ScriptState* pausedScriptState, v8::Local<v8::Object> executionState, v8::Local<v8::Object> eventData);
+ void handleV8PromiseEvent(ScriptState* pausedScriptState, v8::Local<v8::Object> executionState, v8::Local<v8::Object> eventData);
v8::Isolate* m_isolate;
Client* m_client;
« no previous file with comments | « Source/core/inspector/ScriptDebuggerBase.cpp ('k') | Source/core/inspector/V8Debugger.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698