Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1214823002: Revert of [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings (Closed)

Created:
5 years, 5 months ago by Habib Virji
Modified:
5 years, 5 months ago
Reviewers:
piman, dtapuska, Wez, kpschoedel
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tdresser+watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jdduke+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings (patchset #9 id:180001 of https://codereview.chromium.org/929053004/) Reason for revert: This pach is still under review and was accidentally closed. Original issue's description: > [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings > > Embedder API for accessing DOM3 |key| value based on the enum value. > > Sets the dom |key| enum value for each WebKeyboardEvent. Blink then uses the embedded API to translate the dom |key| enum value to a value string. > > It is dependent on CL 1103263004, which sets dom |key| value in X11. > > BUG=227231 > R=piman@chromium.org, Wez TBR=wez@chromium.org,piman@chromium.org,kpschoedel@chromium.org,dtapuska@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=227231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -150 lines) Patch
M components/test_runner/event_sender.cc View 7 chunks +131 lines, -94 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/child/blink_platform_impl.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M ui/events/keycodes/dom/dom_key.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/events/keycodes/dom_us_layout_data.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Habib Virji
5 years, 5 months ago (2015-06-26 19:23:46 UTC) #1
Created Revert of [KeyboardEvent] Add embedder APIs to translate between Dom
|key| enum and strings

Powered by Google App Engine
This is Rietveld 408576698