Chromium Code Reviews| Index: chrome/browser/android/metrics/launch_metrics.cc |
| diff --git a/chrome/browser/android/metrics/launch_metrics.cc b/chrome/browser/android/metrics/launch_metrics.cc |
| index 6abef98306b93fa348e9d164b48b26b6f7fb6b07..fc6b0c1ac3b5d4ae37cb0a744df0f06dbe77a173 100644 |
| --- a/chrome/browser/android/metrics/launch_metrics.cc |
| +++ b/chrome/browser/android/metrics/launch_metrics.cc |
| @@ -43,17 +43,28 @@ static void RecordLaunch(JNIEnv* env, jclass caller, jboolean standalone, |
| base::Time::Now()); |
| } |
| + std::string rappor_metric; |
| + if (source == ShortcutInfo::SOURCE_ADD_TO_HOMESCREEN) |
| + rappor_metric = "Launch.HomeScreenSource.AddToHomeScreen"; |
| + else if (source == ShortcutInfo::SOURCE_APP_BANNER) |
| + rappor_metric = "Launch.HomeScreenSource.AppBanner"; |
| + else |
| + rappor_metric = "Launch.HomeScreenSource.Unknown"; |
| + |
| + UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreenSource", source, |
| + ShortcutInfo::SOURCE_COUNT); |
| + |
| + rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(), |
| + rappor_metric, url); |
| + |
| int action = standalone ? HOME_SCREEN_LAUNCH_STANDALONE |
| : HOME_SCREEN_LAUNCH_SHORTCUT; |
| - std::string rappor_metric = standalone ? "Launch.HomeScreen.Standalone" |
| - : "Launch.HomeScreen.Shortcut"; |
| + rappor_metric = standalone ? "Launch.HomeScreen.Standalone" |
| + : "Launch.HomeScreen.Shortcut"; |
| UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreen", action, |
| HOME_SCREEN_LAUNCH_COUNT); |
| - UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreenSource", source, |
| - ShortcutInfo::SOURCE_COUNT); |
| - |
| rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(), |
|
gone
2015/07/07 17:39:11
duplicated?
dominickn
2015/07/07 23:25:07
It uses a different rappor_metric string the secon
gone
2015/07/07 23:28:56
Ah, I see. It's a little confusing to look at, th
dominickn
2015/07/08 00:02:11
Done.
|
| rappor_metric, url); |
| } |