Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1214713003: Move InstrumentationTestCase tests from ChromeShell to ChromePublic. (Closed)

Created:
5 years, 6 months ago by newt (away)
Modified:
5 years, 5 months ago
Reviewers:
Ted C, Yaron
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, wifiprefetch-reviews_google.com, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move InstrumentationTestCase tests from ChromeShell to ChromePublic. These tests are trivial to migrate from ChromeShell to ChromePublic because they don't actually depend on ChromeShellTestBase. This just moves the files from javatests_shell to javatests and updates some build dependencies. BUG=505040 Committed: https://crrev.com/aff93a2bd1ffeea6137a57d7be647eb2cbb2e82a Cr-Commit-Position: refs/heads/master@{#336776}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : added @VisibleForTesting in homage to ProGuard #

Patch Set 4 : moved IntentSavingContext to chrome/test to fix ChromeShell compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4379 lines) Patch
M base/android/java/src/org/chromium/base/CollectionUtil.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGenerator.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/OAuth2TokenService.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/UrlUtilitiesTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/compositor/eventfilter/MockEventFilterHost.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEventFilterTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/download/OMADownloadHandlerTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGeneratorTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/identity/UniqueIdentificationGeneratorFactoryTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/identity/UuidBasedUniqueIdentificationGeneratorTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncherTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/util/FeatureUtilitiesTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/util/HashUtilTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/UrlUtilitiesTest.java View 1 chunk +0 lines, -176 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/compositor/eventfilter/MockEventFilterHost.java View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEventFilterTest.java View 1 chunk +0 lines, -434 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java View 1 chunk +0 lines, -522 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/download/OMADownloadHandlerTest.java View 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 1 chunk +0 lines, -1207 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGeneratorTest.java View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/identity/UniqueIdentificationGeneratorFactoryTest.java View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/identity/UuidBasedUniqueIdentificationGeneratorTest.java View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/invalidation/IntentSavingContext.java View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java View 1 chunk +0 lines, -293 lines 0 comments Download
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/invalidation/InvalidationServiceTest.java View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncherTest.java View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java View 1 chunk +0 lines, -229 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceTest.java View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java View 1 chunk +0 lines, -435 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/util/FeatureUtilitiesTest.java View 1 chunk +0 lines, -242 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/util/HashUtilTest.java View 1 chunk +0 lines, -24 lines 0 comments Download
A + chrome/test/android/javatests/src/org/chromium/chrome/test/invalidation/IntentSavingContext.java View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/eclipse/.classpath View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 29 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214713003/1
5 years, 6 months ago (2015-06-27 00:32:51 UTC) #2
newt (away)
PTAL
5 years, 6 months ago (2015-06-27 00:33:20 UTC) #4
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 6 months ago (2015-06-27 00:35:10 UTC) #6
Ted C
lgtm
5 years, 5 months ago (2015-06-29 15:32:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214713003/20001
5 years, 5 months ago (2015-06-29 22:13:25 UTC) #10
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-06-29 22:30:20 UTC) #12
newt (away)
+yfriedman for adding @VisibleForTesting to methods in base/ and sync/
5 years, 5 months ago (2015-06-29 23:20:12 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214713003/40001
5 years, 5 months ago (2015-06-29 23:22:10 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/86495)
5 years, 5 months ago (2015-06-29 23:41:30 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214713003/60001
5 years, 5 months ago (2015-06-30 00:35:01 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-30 02:46:37 UTC) #24
Yaron
lgtm
5 years, 5 months ago (2015-06-30 13:53:09 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214713003/60001
5 years, 5 months ago (2015-06-30 13:53:17 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-06-30 13:57:36 UTC) #28
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 13:58:19 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/aff93a2bd1ffeea6137a57d7be647eb2cbb2e82a
Cr-Commit-Position: refs/heads/master@{#336776}

Powered by Google App Engine
This is Rietveld 408576698