chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java - Issue 1214713003: Move InstrumentationTestCase tests from ChromeShell to ChromePublic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java

Issue 1214713003: Move InstrumentationTestCase tests from ChromeShell to ChromePublic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moved IntentSavingContext to chrome/test to fix ChromeShell compile Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/chrome_apk.gyp ('k') | chrome/android/java/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGenerator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java b/chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java

index 33aea29e9b636cb2dc8b848fa71aa677ccaadc8d..76574007b8f12d4389c170873f27a0cac0b68187 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java

@@ -8,6 +8,7 @@ import android.text.TextUtils;

import org.chromium.base.CollectionUtil;

import org.chromium.base.Log;

+import org.chromium.base.VisibleForTesting;

import java.io.UnsupportedEncodingException;

import java.net.URI;

@@ -231,6 +232,7 @@ public class UrlUtilities {

* URL, as specified at

* https://developer.chrome.com/multidevice/android/intents#syntax.

+ @VisibleForTesting

public static boolean validateIntentUrl(String url) {

if (url == null) {

Log.d(TAG, "url was null");