Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 12147005: Hardcode scrollbar rendering for Android (Closed)

Created:
6 years, 9 months ago by trchen
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Hardcoded scrollbar for Android This class a quick hack scrollbar for Android for M25. Need to disable WebKit-side scrollbar for now because sublayer scrollbars aren't coordinated in the compositor, and the update latency is too long when impl-side painting is enabled. We should remove this hack after implementing the coordinator for sublayer scrollbars. BUG=173302

Patch Set 1 #

Patch Set 2 : hardcoded scrollbar not using layer structure. similar to M18 approach #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -0 lines) Patch
M cc/cc.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A cc/hardcoded_scrollbar.h View 1 1 chunk +57 lines, -0 lines 6 comments Download
A cc/hardcoded_scrollbar.cc View 1 1 chunk +181 lines, -0 lines 1 comment Download
M cc/layer_tree_host_impl.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 1 6 chunks +7 lines, -0 lines 1 comment Download
M ui/gfx/vector2d_f.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
trchen
So again I introduced a hardcoded scrollbar that is similar to what we did for ...
6 years, 9 months ago (2013-02-05 10:17:26 UTC) #1
danakj
Some style nits, the new files are mostly in chromium style, but still have webkit ...
6 years, 9 months ago (2013-02-05 17:55:02 UTC) #2
jamesr
Why is it not sufficient to override the thumb painting behavior of the existing scrollbar ...
6 years, 9 months ago (2013-02-05 17:59:36 UTC) #3
trchen
6 years, 9 months ago (2013-02-05 20:33:51 UTC) #4
On 2013/02/05 17:59:36, jamesr wrote:
> Why is it not sufficient to override the thumb painting behavior of the
existing
> scrollbar class?

We used to doubt that scrollbars are causing unnecessary invalidation on the
main layer. I just synced up with xianzhu, he confirmed it was a wrong guess.

So we might not need this quick hack scrollbar after all. aelias@ is suggesting
that implementing proper coordinator for sublayer scrollbars shouldn't be that
difficult. I'll try if I can finish it by tonight then we can abandon this hack.

Powered by Google App Engine
This is Rietveld 408576698