WebDataConsumerHandle shouldn't be used on non-Oilpan threads.

WebDataConsumerHandle shouldn't be used on non-Oilpan threads.

Some WebDataConsumerHandle subclasses use on-heap objects and Oilpan requires
the followings:

- Non-oilpan threads must not touch on-heap objects.
- Objects must not outlive the thread that created the objects. For example, it
is invalid to keep holding a Persistent handle to an object that was created by
a thread already detached.

As a result, such WebDataConsumerHandle subclasses cannot be used
in non-oilpan threads.
We hope we will get rid of this restriction in the future.

BUG=480746
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197982

[yhirano, 2015-06-26 06:33:10]

yhirano@chromium.org changed reviewers:
+ haraken@chromium.org, hiroshige@chromium.org

[haraken, 2015-06-26 06:35:54]

> As some WebDataConsumerHandle have a problem with Persistent reference cleanup
in non-oilpan threads

Would you elaborate on what the restriction is?

The restrictions on the oilpan side are:

- Non-oilpan threads must not touch on-heap objects.
- Objects must not outlive the thread that created the objects. For example, it
is invalid to keep holding a Persistent handle to an object that was created by
a thread already detached.

[haraken, 2015-06-26 06:37:13]

LGTM either way.

[yhirano, 2015-06-26 06:53:36]

Thanks, fixed the issue description.

[hiroshige, 2015-06-26 06:53:39]

lgtm.

[hiroshige, 2015-06-26 06:55:27]

optional: including the word Oilpan in the CL description would be good.

[yhirano, 2015-06-26 06:58:05]

On 2015/06/26 06:55:27, hiroshige wrote:
> optional: including the word Oilpan in the CL description would be good.

Fixed the title.

[yhirano, 2015-06-26 07:09:14]

yhirano@chromium.org changed reviewers:
+ tkent@chromium.org

[yhirano, 2015-06-26 07:09:15]

+tkent for OWNER review.

[tkent, 2015-06-26 07:13:39]

https://codereview.chromium.org/1214613003/diff/1/public/platform/WebDataCons...
File public/platform/WebDataConsumerHandle.h (right):

https://codereview.chromium.org/1214613003/diff/1/public/platform/WebDataCons...
public/platform/WebDataConsumerHandle.h:27: // WebDataConsumerHandle can be
created / used / destructed only on
Can you add an assertion?
for example,  add WebDataConsumerHandler() constructor, and put
ASSERT(ThreadState::current()).

[yhirano, 2015-06-26 11:25:33]

https://codereview.chromium.org/1214613003/diff/1/public/platform/WebDataCons...
File public/platform/WebDataConsumerHandle.h (right):

https://codereview.chromium.org/1214613003/diff/1/public/platform/WebDataCons...
public/platform/WebDataConsumerHandle.h:27: // WebDataConsumerHandle can be
created / used / destructed only on
On 2015/06/26 07:13:38, tkent wrote:
> Can you add an assertion?
> for example,  add WebDataConsumerHandler() constructor, and put
> ASSERT(ThreadState::current()).

Done.

[tkent, 2015-06-28 11:38:50]

lgtm

[yhirano, 2015-06-29 09:15:25]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2015-06-29 09:15:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1214613003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-06-29 09:15:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214613003/40001

[commit-bot: I haz the power, 2015-06-29 09:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-29 09:18:22]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[yhirano, 2015-06-29 10:37:48]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2015-06-29 10:37:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, haraken@chromium.org, tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1214613003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-06-29 10:37:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214613003/60001

[commit-bot: I haz the power, 2015-06-29 11:46:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-29 11:46:52]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/68596)

[yhirano, 2015-06-29 11:48:53]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2015-06-29 11:48:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214613003/60001

[commit-bot: I haz the power, 2015-06-29 12:36:38]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197982