Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: public/platform/WebDataConsumerHandle.h

Issue 1214613003: WebDataConsumerHandle shouldn't be used on non-Oilpan threads. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/exported/WebDataConsumerHandle.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebDataConsumerHandle.h
diff --git a/public/platform/WebDataConsumerHandle.h b/public/platform/WebDataConsumerHandle.h
index 796feff71a3d5cfb205eefaa3009dee6ecd8efc3..d2678816de78401553dc5e8bfd17123cba3907dd 100644
--- a/public/platform/WebDataConsumerHandle.h
+++ b/public/platform/WebDataConsumerHandle.h
@@ -23,6 +23,10 @@ namespace blink {
// A WebDataConsumerHandle having a reader is called "locked". A
// WebDataConsumerHandle or its reader are called "waiting" when reading from
// the handle or reader returns ShouldWait.
+//
+// WebDataConsumerHandle can be created / used / destructed only on
+// Oilpan-enabled threads.
+// TODO(yhirano): Remove this restriction.
class BLINK_PLATFORM_EXPORT WebDataConsumerHandle {
public:
using Flags = unsigned;
@@ -100,7 +104,8 @@ public:
}
};
- virtual ~WebDataConsumerHandle() { }
+ WebDataConsumerHandle();
+ virtual ~WebDataConsumerHandle();
// Returns a non-null reader. This function can be called only when this
// handle is not locked. |client| can be null. Otherwise, |*client| must be
@@ -110,7 +115,7 @@ public:
// If |client| is not null and the handle is not waiting, client
// notification is called asynchronously.
#if INSIDE_BLINK
- PassOwnPtr<Reader> obtainReader(Client* client) { return adoptPtr(obtainReaderInternal(client)); }
+ PassOwnPtr<Reader> obtainReader(Client*);
#endif
// Returns a string literal (e.g. class name) for debugging only.
« no previous file with comments | « Source/platform/exported/WebDataConsumerHandle.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698