Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1214593003: Move AnimationValue onto the heap (Closed)

Created:
5 years, 6 months ago by alancutter (OOO until 2018)
Modified:
5 years, 5 months ago
Reviewers:
dstockwell, shans
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move AnimationValue onto the heap This changes AnimationValue from a struct on the stack to being an object on the heap. This simplifies the implementation of AnimationValue as it no longer needs to reimplement nullptr behaviours and makes future use of this class simpler by reusing the move operations provided by OwnPtr. This change makes FlipPrimitiveInterpolation::Side redundant and removes it. BUG=437696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -85 lines) Patch
M Source/core/animation/AnimationType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationValue.h View 1 chunk +27 lines, -32 lines 0 comments Download
M Source/core/animation/CSSValueAnimationType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CSSValueAnimationType.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/animation/InvalidatableStyleInterpolation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/InvalidatableStyleInterpolation.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/animation/PrimitiveInterpolation.h View 5 chunks +27 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
alancutter (OOO until 2018)
This patch is split out from https://codereview.chromium.org/1215563002.
5 years, 6 months ago (2015-06-26 04:29:49 UTC) #2
shans
lgtm++, nice cleanup
5 years, 5 months ago (2015-06-29 01:30:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214593003/1
5 years, 5 months ago (2015-06-29 04:04:01 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 05:43:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197963

Powered by Google App Engine
This is Rietveld 408576698