Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214573003: Fix Polymer licensing issues (Closed)

Created:
5 years, 6 months ago by michaelpg
Modified:
5 years, 6 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Polymer licensing issues NOPRESUBMIT=true (long lines) R=dzhioev@chromium.org Committed: https://crrev.com/610a9be5bcd65d832fbe5065cdde1f9435074296 Cr-Commit-Position: refs/heads/master@{#336446}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix web-animations-js path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -9026 lines) Patch
M content/browser/webui/shared_resources_data_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-ajax/.bower.json View 1 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-ajax/.gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-ajax/README.md View 1 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-ajax/bower.json View 1 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-ajax/index.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-ajax/iron-ajax.html View 1 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-ajax/iron-ajax-extracted.js View 1 1 chunk +0 lines, -399 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-ajax/iron-request.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-ajax/iron-request-extracted.js View 1 1 chunk +0 lines, -251 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-form/.bower.json View 1 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-form/.gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-form/README.md View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-form/bower.json View 1 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-form/index.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-form/iron-form.html View 1 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-form/iron-form-extracted.js View 1 1 chunk +0 lines, -219 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/.bower.json View 1 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/Gruntfile.js View 1 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/LICENSE View 1 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/Promise.js View 1 1 chunk +0 lines, -128 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/Promise-Statics.js View 1 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/Promise.min.js View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/README.md View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/bower.json View 1 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/package.json View 1 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/promise-polyfill.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/promise-polyfill-lite.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/promise-polyfill/promise-polyfill-lite-extracted.js View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/.bower.json View 1 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/COPYING View 1 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/History.md View 1 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/README.md View 1 1 chunk +0 lines, -161 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/bower.json View 1 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/web-animations.html View 1 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/web-animations-next-lite.min.js View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/web-animations-next-lite.min.js.map View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/web-animations-next.min.js View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/web-animations-next.min.js.map View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/web-animations.min.js View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/web-animations-js/web-animations.min.js.map View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components/iron-ajax/.bower.json View 1 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/polymer/v1_0/components/iron-ajax/.gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components/iron-ajax/README.md View 1 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/polymer/v1_0/components/iron-ajax/bower.json View 1 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/polymer/v1_0/components/iron-ajax/index.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/polymer/v1_0/components/iron-ajax/iron-ajax.html View 1 1 chunk +0 lines, -436 lines 0 comments Download
D third_party/polymer/v1_0/components/iron-ajax/iron-request.html View 1 1 chunk +0 lines, -272 lines 0 comments Download
D third_party/polymer/v1_0/components/iron-form/.bower.json View 1 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/polymer/v1_0/components/iron-form/.gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components/iron-form/README.md View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components/iron-form/bower.json View 1 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/polymer/v1_0/components/iron-form/index.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/polymer/v1_0/components/iron-form/iron-form.html View 1 1 chunk +0 lines, -233 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/.bower.json View 1 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/Gruntfile.js View 1 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/LICENSE View 1 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/Promise.js View 1 1 chunk +0 lines, -128 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/Promise-Statics.js View 1 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/Promise.min.js View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/README.md View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/bower.json View 1 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/package.json View 1 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/promise-polyfill.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components/promise-polyfill/promise-polyfill-lite.html View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/.bower.json View 1 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/COPYING View 1 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/History.md View 1 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/README.md View 1 1 chunk +0 lines, -161 lines 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/bower.json View 1 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/web-animations.html View 1 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/web-animations-next-lite.min.js View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/web-animations-next-lite.min.js.map View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/web-animations-next.min.js View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/web-animations-next.min.js.map View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/web-animations.min.js View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components/web-animations-js/web-animations.min.js.map View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/reproduce.sh View 1 1 chunk +12 lines, -3 lines 0 comments Download
M third_party/web-animations-js/README.chromium View 1 2 chunks +5 lines, -12 lines 0 comments Download
M third_party/web-animations-js/sources/.bower.json View 1 1 chunk +32 lines, -5 lines 0 comments Download
D third_party/web-animations-js/sources/.travis.yml View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/web-animations-js/sources/Gruntfile.js View 1 1 chunk +0 lines, -279 lines 0 comments Download
M third_party/web-animations-js/sources/History.md View 1 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/web-animations-js/sources/README.md View 1 5 chunks +12 lines, -12 lines 0 comments Download
A + third_party/web-animations-js/sources/bower.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/web-animations-js/sources/package.json View 1 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/web-animations-js/sources/src/animation.js View 1 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/web-animations-js/sources/src/animation-constructor.js View 1 1 chunk +0 lines, -144 lines 0 comments Download
D third_party/web-animations-js/sources/src/animation-node.js View 1 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/web-animations-js/sources/src/apply.js View 1 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/web-animations-js/sources/src/apply-preserving-inline-style.js View 1 1 chunk +0 lines, -191 lines 0 comments Download
D third_party/web-animations-js/sources/src/box-handler.js View 1 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/web-animations-js/sources/src/color-handler.js View 1 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/web-animations-js/sources/src/deprecation.js View 1 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/web-animations-js/sources/src/dev.js View 1 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/web-animations-js/sources/src/dimension-handler.js View 1 1 chunk +0 lines, -167 lines 0 comments Download
D third_party/web-animations-js/sources/src/effect.js View 1 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/web-animations-js/sources/src/effect-callback.js View 1 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/web-animations-js/sources/src/element-animatable.js View 1 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/web-animations-js/sources/src/font-weight-handler.js View 1 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/web-animations-js/sources/src/group-constructors.js View 1 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/web-animations-js/sources/src/handler-utils.js View 1 1 chunk +0 lines, -177 lines 0 comments Download
D third_party/web-animations-js/sources/src/interpolation.js View 1 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/web-animations-js/sources/src/matrix-decomposition.js View 1 1 chunk +0 lines, -452 lines 0 comments Download
D third_party/web-animations-js/sources/src/matrix-interpolation.js View 1 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/web-animations-js/sources/src/normalize-keyframes.js View 1 1 chunk +0 lines, -259 lines 0 comments Download
D third_party/web-animations-js/sources/src/number-handler.js View 1 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/web-animations-js/sources/src/player.js View 1 1 chunk +0 lines, -193 lines 0 comments Download
D third_party/web-animations-js/sources/src/position-handler.js View 1 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/web-animations-js/sources/src/property-interpolation.js View 1 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/web-animations-js/sources/src/property-names.js View 1 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/web-animations-js/sources/src/scope.js View 1 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/web-animations-js/sources/src/shadow-handler.js View 1 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/web-animations-js/sources/src/shape-handler.js View 1 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/web-animations-js/sources/src/tick.js View 1 1 chunk +0 lines, -148 lines 0 comments Download
D third_party/web-animations-js/sources/src/timeline.js View 1 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/web-animations-js/sources/src/timing-utilities.js View 1 1 chunk +0 lines, -242 lines 0 comments Download
D third_party/web-animations-js/sources/src/transform-handler.js View 1 1 chunk +0 lines, -262 lines 0 comments Download
D third_party/web-animations-js/sources/src/visibility-handler.js View 1 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/web-animations-js/sources/src/web-animations-next-player.js View 1 1 chunk +0 lines, -162 lines 0 comments Download
D third_party/web-animations-js/sources/target-config.js View 1 1 chunk +0 lines, -124 lines 0 comments Download
D third_party/web-animations-js/sources/target-loader.js View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/web-animations-js/sources/templates/boilerplate View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/web-animations-js/sources/templates/runner.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/web-animations-js/sources/templates/web-animations.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/web-animations-js/sources/templates/web-animations.js View 1 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/web-animations-js/sources/web-animations-next-lite.dev.html View 1 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/web-animations-js/sources/web-animations-next-lite.dev.js View 1 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/web-animations-js/sources/web-animations-next-lite.min.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/web-animations-js/sources/web-animations-next-lite.min.js.map View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/web-animations-js/sources/web-animations-next.dev.html View 1 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/web-animations-js/sources/web-animations-next.dev.js View 1 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/web-animations-js/sources/web-animations-next.min.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/web-animations-js/sources/web-animations-next.min.js.map View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/web-animations-js/sources/web-animations.dev.html View 1 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/web-animations-js/sources/web-animations.dev.js View 1 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/web-animations-js/sources/web-animations.min.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/web-animations-js/sources/web-animations.min.js.map View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/polymer/txt_to_polymer_grdp.py View 1 1 chunk +3 lines, -6 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 6 chunks +20 lines, -26 lines 0 comments Download

Dependent Patchsets:

Issue 1215543002 Patch 10001
Issue 1215543002 Patch 30001

Messages

Total messages: 11 (2 generated)
michaelpg
PTAL
5 years, 6 months ago (2015-06-26 04:00:38 UTC) #1
dzhioev (left Google)
https://codereview.chromium.org/1214573003/diff/1/ui/webui/resources/polymer_resources.grdp File ui/webui/resources/polymer_resources.grdp (right): https://codereview.chromium.org/1214573003/diff/1/ui/webui/resources/polymer_resources.grdp#newcode1110 ui/webui/resources/polymer_resources.grdp:1110: file="../../../third_party/web-animations-js/sources/web-animations-next-lite.min.js" I believe you need to change mappings in ...
5 years, 6 months ago (2015-06-26 04:18:48 UTC) #2
michaelpg
https://codereview.chromium.org/1214573003/diff/1/ui/webui/resources/polymer_resources.grdp File ui/webui/resources/polymer_resources.grdp (right): https://codereview.chromium.org/1214573003/diff/1/ui/webui/resources/polymer_resources.grdp#newcode1110 ui/webui/resources/polymer_resources.grdp:1110: file="../../../third_party/web-animations-js/sources/web-animations-next-lite.min.js" On 2015/06/26 04:18:47, dzhioev wrote: > I believe ...
5 years, 6 months ago (2015-06-26 04:25:12 UTC) #3
dzhioev (left Google)
LGTM
5 years, 6 months ago (2015-06-26 04:29:24 UTC) #4
michaelpg
+jhawkins@ for content/browser/webui
5 years, 6 months ago (2015-06-26 04:37:33 UTC) #6
James Hawkins
lgtm
5 years, 6 months ago (2015-06-26 16:51:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214573003/10001
5 years, 6 months ago (2015-06-26 17:36:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:10001)
5 years, 6 months ago (2015-06-26 19:55:04 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 19:56:07 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/610a9be5bcd65d832fbe5065cdde1f9435074296
Cr-Commit-Position: refs/heads/master@{#336446}

Powered by Google App Engine
This is Rietveld 408576698