Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 1214533003: Mark 3 webexposed/global-interface-listing tests as failing after r198026 (Closed)

Created:
5 years, 5 months ago by caseq
Modified:
5 years, 5 months ago
Reviewers:
adamk
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mark 3 webexposed/global-interface-listing tests as failing after r198026 https://codereview.chromium.org/1217073002 removed [ NeedsManualRebaseline ] for these tests, however, these still fail on default (non-virtual) path. Note that since these don't seem to fail to ASAN/MSAN bots, these are likely racy flakes actually. BUG=502308 TBR=adamk,japhet NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214533003/1
5 years, 5 months ago (2015-06-30 09:26:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198044
5 years, 5 months ago (2015-06-30 09:30:23 UTC) #3
adamk
5 years, 5 months ago (2015-06-30 16:37:07 UTC) #5
Message was sent while issue was closed.
The tests aren't "still" failing, they're simply failing "again". These tests
are quite dumb, simply enumerating all constructors on the global object and all
the properties on their prototypes. It looks like mek removed navigator.connect
in https://src.chromium.org/viewvc/blink?revision=198024&view=revision, and this
happened to land around the same time as my patch.

Powered by Google App Engine
This is Rietveld 408576698