Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1217073002: Rebaseline global-interface-listing tests after V8 flag flip (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
Reviewers:
pdr.
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rebaseline global-interface-listing tests after V8 flag flip V8 enabled the --harmony-arrays flag by default in https://chromium.googlesource.com/v8/v8/+/325fbd0, adding many methods to Array and the various TypedArrays. The intent to ship was posted to v8-users: https://groups.google.com/forum/#!msg/v8-users/WIdC-t1zmKQ/lXpufXhNj3UJ This patch adds the appropriate expectations for the aforementioned methods, as well as several bits that changed while these tests were disabled: - Added CanvasRenderingContext2D#filter (runtime enabled) - Added MediaDevices#getUserMedia (runtime enabled) - Added PerformanceResourceTiming#workerStart - Removed ServiceWorker#terminate From my review of the commit log, all four of the above changes were intentional and appropriate. BUG=502308 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198026

Patch Set 1 #

Patch Set 2 : Fixed virtual stable expectations #

Messages

Total messages: 11 (5 generated)
adamk
5 years, 5 months ago (2015-06-29 20:26:44 UTC) #2
pdr.
On 2015/06/29 at 20:26:44, adamk wrote: > LGTM
5 years, 5 months ago (2015-06-29 20:30:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217073002/1
5 years, 5 months ago (2015-06-29 20:33:05 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-06-29 21:41:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217073002/20001
5 years, 5 months ago (2015-06-29 21:49:55 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 23:13:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198026

Powered by Google App Engine
This is Rietveld 408576698