Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: components/error_page/renderer/net_error_helper_core.h

Issue 1214303003: Add UMA histograms for Google cached copy experiment on network error interstitial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix NetErrorHelperCore unittest Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/error_page/renderer/net_error_helper_core.h
diff --git a/components/error_page/renderer/net_error_helper_core.h b/components/error_page/renderer/net_error_helper_core.h
index c8ac3293382da8c5978379d7ac086f2cc9c0e58d..7f7fafb6ceb90a1b9c9aa4e6a1bc244014f31def 100644
--- a/components/error_page/renderer/net_error_helper_core.h
+++ b/components/error_page/renderer/net_error_helper_core.h
@@ -48,6 +48,8 @@ class NetErrorHelperCore {
SHOW_SAVED_COPY_BUTTON,
MORE_BUTTON,
EASTER_EGG,
+ SHOW_CACHED_COPY_BUTTON, // "Google cached copy" button label experiment.
+ SHOW_CACHED_PAGE_BUTTON, // "Google cached page" button label experiment.
BUTTON_MAX,
};
@@ -62,6 +64,8 @@ class NetErrorHelperCore {
scoped_ptr<error_page::ErrorPageParams> params,
bool* reload_button_shown,
bool* show_saved_copy_button_shown,
+ bool* show_cached_copy_button_shown,
+ bool* show_cached_page_button_shown,
std::string* html) const = 0;
// Loads the given HTML in the main frame for use as an error page.
« no previous file with comments | « components/error_page/common/net_error_info.h ('k') | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698