Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: components/error_page/common/net_error_info.h

Issue 1214303003: Add UMA histograms for Google cached copy experiment on network error interstitial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix NetErrorHelperCore unittest Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/neterror.js ('k') | components/error_page/renderer/net_error_helper_core.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/error_page/common/net_error_info.h
diff --git a/components/error_page/common/net_error_info.h b/components/error_page/common/net_error_info.h
index 071bbd640107d683c76c1314f5aca20e104d8c88..39b6aaedd32d0432a8bdd1f499e57c8139c49af9 100644
--- a/components/error_page/common/net_error_info.h
+++ b/components/error_page/common/net_error_info.h
@@ -10,30 +10,36 @@ namespace chrome_common_net {
// Network error page events. Used for UMA statistics.
enum NetworkErrorPageEvent {
- NETWORK_ERROR_PAGE_SHOWN, // Error pages shown.
+ NETWORK_ERROR_PAGE_SHOWN = 0, // Error pages shown.
- NETWORK_ERROR_PAGE_RELOAD_BUTTON_SHOWN, // Reload buttons shown.
- NETWORK_ERROR_PAGE_RELOAD_BUTTON_CLICKED, // Reload button clicked.
- NETWORK_ERROR_PAGE_RELOAD_BUTTON_ERROR, // Reload button clicked
- // -> error.
+ NETWORK_ERROR_PAGE_RELOAD_BUTTON_SHOWN = 1, // Reload buttons shown.
+ NETWORK_ERROR_PAGE_RELOAD_BUTTON_CLICKED = 2, // Reload button clicked.
+ NETWORK_ERROR_PAGE_RELOAD_BUTTON_ERROR = 3, // Reload button clicked
+ // -> error.
// Same for the "Show saved copy" button.
- NETWORK_ERROR_PAGE_SHOW_SAVED_COPY_BUTTON_SHOWN,
- NETWORK_ERROR_PAGE_SHOW_SAVED_COPY_BUTTON_CLICKED,
- NETWORK_ERROR_PAGE_SHOW_SAVED_COPY_BUTTON_ERROR,
+ NETWORK_ERROR_PAGE_SHOW_SAVED_COPY_BUTTON_SHOWN = 4,
+ NETWORK_ERROR_PAGE_SHOW_SAVED_COPY_BUTTON_CLICKED = 5,
+ NETWORK_ERROR_PAGE_SHOW_SAVED_COPY_BUTTON_ERROR = 6,
- NETWORK_ERROR_PAGE_MORE_BUTTON_CLICKED, // More button clicked.
+ NETWORK_ERROR_PAGE_MORE_BUTTON_CLICKED = 7, // More button clicked.
- NETWORK_ERROR_PAGE_BROWSER_INITIATED_RELOAD, // Reload from browser.
+ NETWORK_ERROR_PAGE_BROWSER_INITIATED_RELOAD = 8, // Reload from browser.
// Keep track of which button the user chooses when both are shown.
- NETWORK_ERROR_PAGE_BOTH_BUTTONS_SHOWN,
- NETWORK_ERROR_PAGE_BOTH_BUTTONS_RELOAD_CLICKED,
- NETWORK_ERROR_PAGE_BOTH_BUTTONS_SHOWN_SAVED_COPY_CLICKED,
+ NETWORK_ERROR_PAGE_BOTH_BUTTONS_SHOWN = 9,
+ NETWORK_ERROR_PAGE_BOTH_BUTTONS_RELOAD_CLICKED = 10,
+ NETWORK_ERROR_PAGE_BOTH_BUTTONS_SHOWN_SAVED_COPY_CLICKED = 11,
- NETWORK_ERROR_EASTER_EGG_ACTIVATED, // Easter egg activated.
+ NETWORK_ERROR_EASTER_EGG_ACTIVATED = 12, // Easter egg activated.
- NETWORK_ERROR_PAGE_EVENT_MAX,
+ // For "Google cached copy" label experiment button.
+ NETWORK_ERROR_PAGE_CACHED_COPY_BUTTON_SHOWN = 13,
+ NETWORK_ERROR_PAGE_CACHED_COPY_BUTTON_CLICKED = 14,
+ NETWORK_ERROR_PAGE_CACHED_PAGE_BUTTON_SHOWN = 15,
+ NETWORK_ERROR_PAGE_CACHED_PAGE_BUTTON_CLICKED = 16,
+
+ NETWORK_ERROR_PAGE_EVENT_MAX = 17,
};
// The status of a DNS probe.
« no previous file with comments | « chrome/renderer/resources/neterror.js ('k') | components/error_page/renderer/net_error_helper_core.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698