Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1952)

Unified Diff: chrome/renderer/net/net_error_page_controller.cc

Issue 1214303003: Add UMA histograms for Google cached copy experiment on network error interstitial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix NetErrorHelperCore unittest Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | chrome/renderer/resources/neterror.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/net/net_error_page_controller.cc
diff --git a/chrome/renderer/net/net_error_page_controller.cc b/chrome/renderer/net/net_error_page_controller.cc
index b06bfd01adfe62213153d8b977eda5a541cb45b9..2f690c2643538e28413038bcbdcb6ba034198aae 100644
--- a/chrome/renderer/net/net_error_page_controller.cc
+++ b/chrome/renderer/net/net_error_page_controller.cc
@@ -52,6 +52,12 @@ bool NetErrorPageController::TrackEasterEgg() {
return ButtonClick(error_page::NetErrorHelperCore::EASTER_EGG);
}
+bool NetErrorPageController::TrackCachedCopyButtonClick(bool is_default_label) {
+ return is_default_label ?
+ ButtonClick(error_page::NetErrorHelperCore::SHOW_CACHED_PAGE_BUTTON) :
+ ButtonClick(error_page::NetErrorHelperCore::SHOW_CACHED_COPY_BUTTON);
+}
+
bool NetErrorPageController::TrackClick(const gin::Arguments& args) {
if (!render_frame())
return false;
@@ -98,7 +104,9 @@ gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder(
.SetMethod("trackClick",
&NetErrorPageController::TrackClick)
.SetMethod("trackEasterEgg",
- &NetErrorPageController::TrackEasterEgg);
+ &NetErrorPageController::TrackEasterEgg)
+ .SetMethod("trackCachedCopyButtonClick",
+ &NetErrorPageController::TrackCachedCopyButtonClick);
}
void NetErrorPageController::OnDestruct() {}
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | chrome/renderer/resources/neterror.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698