Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/renderer/net/net_error_page_controller.cc

Issue 1214303003: Add UMA histograms for Google cached copy experiment on network error interstitial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix NetErrorHelperCore unittest Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | chrome/renderer/resources/neterror.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/net/net_error_page_controller.h" 5 #include "chrome/renderer/net/net_error_page_controller.h"
6 6
7 #include "base/strings/string_piece.h" 7 #include "base/strings/string_piece.h"
8 #include "chrome/renderer/net/net_error_helper.h" 8 #include "chrome/renderer/net/net_error_helper.h"
9 #include "content/public/renderer/render_frame.h" 9 #include "content/public/renderer/render_frame.h"
10 #include "gin/handle.h" 10 #include "gin/handle.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 } 45 }
46 46
47 bool NetErrorPageController::DetailsButtonClick() { 47 bool NetErrorPageController::DetailsButtonClick() {
48 return ButtonClick(error_page::NetErrorHelperCore::MORE_BUTTON); 48 return ButtonClick(error_page::NetErrorHelperCore::MORE_BUTTON);
49 } 49 }
50 50
51 bool NetErrorPageController::TrackEasterEgg() { 51 bool NetErrorPageController::TrackEasterEgg() {
52 return ButtonClick(error_page::NetErrorHelperCore::EASTER_EGG); 52 return ButtonClick(error_page::NetErrorHelperCore::EASTER_EGG);
53 } 53 }
54 54
55 bool NetErrorPageController::TrackCachedCopyButtonClick(bool is_default_label) {
56 return is_default_label ?
57 ButtonClick(error_page::NetErrorHelperCore::SHOW_CACHED_PAGE_BUTTON) :
58 ButtonClick(error_page::NetErrorHelperCore::SHOW_CACHED_COPY_BUTTON);
59 }
60
55 bool NetErrorPageController::TrackClick(const gin::Arguments& args) { 61 bool NetErrorPageController::TrackClick(const gin::Arguments& args) {
56 if (!render_frame()) 62 if (!render_frame())
57 return false; 63 return false;
58 64
59 if (!args.PeekNext()->IsInt32()) 65 if (!args.PeekNext()->IsInt32())
60 return false; 66 return false;
61 67
62 NetErrorHelper* net_error_helper = 68 NetErrorHelper* net_error_helper =
63 content::RenderFrameObserverTracker<NetErrorHelper>::Get(render_frame()); 69 content::RenderFrameObserverTracker<NetErrorHelper>::Get(render_frame());
64 DCHECK(net_error_helper); 70 DCHECK(net_error_helper);
(...skipping 26 matching lines...) Expand all
91 isolate) 97 isolate)
92 .SetMethod("showSavedCopyButtonClick", 98 .SetMethod("showSavedCopyButtonClick",
93 &NetErrorPageController::ShowSavedCopyButtonClick) 99 &NetErrorPageController::ShowSavedCopyButtonClick)
94 .SetMethod("reloadButtonClick", 100 .SetMethod("reloadButtonClick",
95 &NetErrorPageController::ReloadButtonClick) 101 &NetErrorPageController::ReloadButtonClick)
96 .SetMethod("detailsButtonClick", 102 .SetMethod("detailsButtonClick",
97 &NetErrorPageController::DetailsButtonClick) 103 &NetErrorPageController::DetailsButtonClick)
98 .SetMethod("trackClick", 104 .SetMethod("trackClick",
99 &NetErrorPageController::TrackClick) 105 &NetErrorPageController::TrackClick)
100 .SetMethod("trackEasterEgg", 106 .SetMethod("trackEasterEgg",
101 &NetErrorPageController::TrackEasterEgg); 107 &NetErrorPageController::TrackEasterEgg)
108 .SetMethod("trackCachedCopyButtonClick",
109 &NetErrorPageController::TrackCachedCopyButtonClick);
102 } 110 }
103 111
104 void NetErrorPageController::OnDestruct() {} 112 void NetErrorPageController::OnDestruct() {}
OLDNEW
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | chrome/renderer/resources/neterror.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698