Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 12143002: Move enable_web_intents down one level, so that it's visible in features.gypi (Closed)

Created:
8 years, 1 month ago by Nico
Modified:
8 years, 1 month ago
Reviewers:
tony, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Move enable_web_intents down one level, so that it's visible in features.gypi Necessary for https://bugs.webkit.org/show_bug.cgi?id=108421 Once both pieces are in, the web intents code will no longer be built in chromium/android. That it's currently built looks like an accident, given that enable_web_intents is explicitly set to 0 in common.gypi. BUG=173194 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M build/common.gypi View 6 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
This is following the use_default_render_theme setting in common.gypi.
8 years, 1 month ago (2013-01-31 22:05:11 UTC) #1
scottmg
lgtm
8 years, 1 month ago (2013-01-31 22:22:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12143002/1
8 years, 1 month ago (2013-01-31 22:26:12 UTC) #3
tony
8 years, 1 month ago (2013-01-31 22:33:14 UTC) #4
lgtm2

Powered by Google App Engine
This is Rietveld 408576698