Issue 121423002: Use proper clang plugin name in GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 121423002: Use proper clang plugin name in GN build. (Closed)

Created:
6 years, 12 months ago by brettw

Modified:
6 years, 12 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use proper clang plugin name in GN build. This uses the proper name of the Clang plugin on Linux (previously it was hardcoded to the Mac-style name). This also fixes the path naming so the clang plugin is correct no matter where the output directory is. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242573

Patch Set 1 #

Patch Set 2 : Fix path #

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	build/config/clang/BUILD.gn	View	1	1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 12 months ago (2013-12-26 23:11:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r242573 (presubmit successful).

Expand Messages | Collapse Messages