Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: build/config/clang/BUILD.gn

Issue 121423002: Use proper clang plugin name in GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix path Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("find_bad_constructs") { 5 config("find_bad_constructs") {
6 cflags = [ 6 cflags = [
7 "-Xclang", "-load", 7 "-Xclang", "-load",
8 "-Xclang", 8 "-Xclang",
9 ]
9 10
10 # TODO(brettw) express this in terms of a relative dir from the output. 11 if (is_mac) {
11 # for now, assume the output dir is two levels deep under the source 12 cflags += rebase_path(
12 # (like "out/Debug"). 13 "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib",
13 "../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib ", 14 ".", root_build_dir)
15 } else if (is_linux) {
16 cflags += rebase_path(
17 "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so",
18 ".", root_build_dir)
19 }
14 20
21 cflags += [
15 "-Xclang", "-add-plugin", 22 "-Xclang", "-add-plugin",
16 "-Xclang", "find-bad-constructs", 23 "-Xclang", "find-bad-constructs",
17 ] 24 ]
18 } 25 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698