Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214203004: cleanup GLBenches (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweaks #

Patch Set 4 : tweaks #

Patch Set 5 : windows warnings #

Patch Set 6 : cpu warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -526 lines) Patch
A bench/GLBench.h View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A bench/GLBench.cpp View 1 2 3 4 5 1 chunk +174 lines, -0 lines 0 comments Download
M bench/GLInstancedArraysBench.cpp View 1 10 chunks +31 lines, -351 lines 0 comments Download
M bench/GLVertexAttributesBench.cpp View 1 2 3 9 chunks +25 lines, -175 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
joshualitt
I could do more consolidation, but I think this is probably enough for now.
5 years, 5 months ago (2015-07-01 17:41:16 UTC) #2
bsalomon
lgtm
5 years, 5 months ago (2015-07-01 18:21:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214203004/20001
5 years, 5 months ago (2015-07-01 18:26:38 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-07-01 18:27:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214203004/80001
5 years, 5 months ago (2015-07-01 18:57:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/1651)
5 years, 5 months ago (2015-07-01 19:11:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214203004/100001
5 years, 5 months ago (2015-07-01 19:31:04 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 19:39:10 UTC) #16
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/74a07db2df189320d4f5804078dc2085b2d38d7c

Powered by Google App Engine
This is Rietveld 408576698