Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/zlib/BUILD.gn

Issue 1214113010: Add local suppresion for -Wparentheses and enable everywhere on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moo Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cloud_print/service/win/service.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/zlib/BUILD.gn
diff --git a/third_party/zlib/BUILD.gn b/third_party/zlib/BUILD.gn
index 1cea9acb9835b079bf3e9f7e34eb3fa773b63af3..a1317f222908687b218ae7724bd6a4677669b79e 100644
--- a/third_party/zlib/BUILD.gn
+++ b/third_party/zlib/BUILD.gn
@@ -102,17 +102,20 @@ static_library("minizip") {
defines = [ "USE_FILE32API" ]
}
- if (is_clang) {
- # zlib uses `if ((a == b))` for some reason.
- cflags = [ "-Wno-parentheses-equality" ]
- }
-
deps = [
":zlib",
]
+ config("minizip_warnings") {
+ if (is_clang) {
+ # zlib uses `if ((a == b))` for some reason.
+ cflags = [ "-Wno-parentheses-equality" ]
+ }
+ }
+
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [ ":minizip_warnings" ]
public_configs = [ ":zlib_config" ]
}
« no previous file with comments | « cloud_print/service/win/service.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698