cloud_print/service/win/service.gyp - Issue 1214113010: Add local suppresion for -Wparentheses and enable everywhere on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/service.gyp

Issue 1214113010: Add local suppresion for -Wparentheses and enable everywhere on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moo Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cloud_print/service/win/service.gyp

diff --git a/cloud_print/service/win/service.gyp b/cloud_print/service/win/service.gyp

index 1221842d988bcdc83ef557f37b29f15147eb0db5..a00c5d361e86c79331a7e0099252e53db164d91d 100644

--- a/cloud_print/service/win/service.gyp

+++ b/cloud_print/service/win/service.gyp

@@ -80,11 +80,15 @@

'conditions': [

['clang==1', {

- # atlapp.h contains a global "using namespace WTL;".

# TODO: Remove once cloud_print_service_config.cc no longer depends

# on atlapp.h, http://crbug.com/5027

'VCCLCompilerTool': {

- 'AdditionalOptions': ['-Wno-header-hygiene'],

+ 'AdditionalOptions': [

+ # atlapp.h contains a global "using namespace WTL;".

+ '-Wno-header-hygiene',

+ # atlgdi.h does an intentional assignment in an if conditional.

+ '-Wno-parentheses',

+ ],

}],

« no previous file with comments | « cloud_print/service/BUILD.gn ('k') | third_party/zlib/BUILD.gn » ('j') | no next file with comments »