Add local suppresion for -Wparentheses and enable everywhere on Windows.

Add local suppresion for -Wparentheses and enable everywhere on Windows.

The Cloud Print Windows service uses WTL, and one of the headers uses
an assignment inside a conditional (atlgdi.h), which triggers this clang
warning.

BUG=505302
TBR=scottbyer@chromium.org,vitalybuka@chromium.org

Committed: https://crrev.com/700bce216cb9399ce306850ee66d3ce5a68c4cfa
Cr-Commit-Position: refs/heads/master@{#336964}

[dcheng, 2015-06-30 18:08:35]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org

[dcheng, 2015-06-30 18:08:36]

This depends on the ICU patch.

[Nico, 2015-06-30 18:09:41]

lgtm

I guess cloud_print doesn't have .gn files yet?

[dcheng, 2015-06-30 18:12:52]

On 2015/06/30 at 18:09:41, thakis wrote:
> lgtm
> 
> I guess cloud_print doesn't have .gn files yet?

Ack, I missed it since it's not in the same directory as the gyp. I'll update
it.

[dcheng, 2015-06-30 21:34:20]

Are there trybots by any chance?

Building a full gyp clang build and then a full gn clang build isn't the fastest
thing in the world =)

(I also fixed a bad warning suppression in minizip along the way)

https://codereview.chromium.org/1214113010/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1214113010/diff/40001/BUILD.gn#newcode859
BUILD.gn:859: "//cloud_print:cloud_print_unittests",
Please ignore this, I'll revert this before landing. I needed this to test the
cloud_print target.

[Nico, 2015-06-30 21:50:39]

On 2015/06/30 21:34:20, dcheng wrote:
> Are there trybots by any chance?

Not yet, sorry. (I checked in the configs for them this morning. After a master
restart they'll exist, but they'll probably need some more work until they
actually work – I usually don't get the configs right on the first try).

> Building a full gyp clang build and then a full gn clang build isn't the
fastest
> thing in the world =)

Just land. I watch
http://build.chromium.org/p/chromium.fyi/console?category=win%20clang pretty
much 24/7, I'll let you know if some config is unhappy.

> (I also fixed a bad warning suppression in minizip along the way)

(looks good. Note that this is technically only needed for warnings that are in
-Wall; not sure if that's the case here. But looks good anyway)

> https://codereview.chromium.org/1214113010/diff/40001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/1214113010/diff/40001/BUILD.gn#newcode859
> BUILD.gn:859: "//cloud_print:cloud_print_unittests",
> Please ignore this, I'll revert this before landing. I needed this to test the
> cloud_print target.

Ok.

[dcheng, 2015-06-30 21:55:08]

On 2015/06/30 at 21:50:39, thakis wrote:
> On 2015/06/30 21:34:20, dcheng wrote:
> > Are there trybots by any chance?
> 
> Not yet, sorry. (I checked in the configs for them this morning. After a
master restart they'll exist, but they'll probably need some more work until
they actually work – I usually don't get the configs right on the first try).
> 
> > Building a full gyp clang build and then a full gn clang build isn't the
fastest
> > thing in the world =)
> 
> Just land. I watch
http://build.chromium.org/p/chromium.fyi/console?category=win%20clang pretty
much 24/7, I'll let you know if some config is unhappy.
> 
> > (I also fixed a bad warning suppression in minizip along the way)
> 
> (looks good. Note that this is technically only needed for warnings that are
in -Wall; not sure if that's the case here. But looks good anyway)

Well, I was getting warnings for it anyway =)

> 
> > https://codereview.chromium.org/1214113010/diff/40001/BUILD.gn
> > File BUILD.gn (right):
> > 
> > https://codereview.chromium.org/1214113010/diff/40001/BUILD.gn#newcode859
> > BUILD.gn:859: "//cloud_print:cloud_print_unittests",
> > Please ignore this, I'll revert this before landing. I needed this to test
the
> > cloud_print target.
> 
> Ok.

[dcheng, 2015-06-30 22:24:39]

dcheng@chromium.org changed reviewers:
+ scottbyer@chromium.org, vitalybuka@chromium.org

[dcheng, 2015-06-30 22:24:39]

TBRing cloud_print (vitalybuka@) and third_party/zlib (scottbyer@) owners.

[dcheng, 2015-06-30 22:24:42]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-06-30 22:24:42]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1214113010/#ps60001
(title: "moo")

[commit-bot: I haz the power, 2015-06-30 22:27:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214113010/60001

[Nico, 2015-06-30 22:29:52]

don't you need to roll icu if it depends on that?

On Tue, Jun 30, 2015 at 3:27 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1214113010/60001
>
>
> https://codereview.chromium.org/1214113010/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dcheng, 2015-06-30 22:33:15]

The CQ bit was unchecked by dcheng@chromium.org

[dcheng, 2015-06-30 22:33:21]

Oh... I assumed it happened magically somewhere... =P

On Tue, Jun 30, 2015 at 3:29 PM Nico Weber <thakis@chromium.org> wrote:

> don't you need to roll icu if it depends on that?
>
> On Tue, Jun 30, 2015 at 3:27 PM, commit-bot@chromium.org via
> codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com>
> wrote:
>
>> CQ is trying da patch. Follow status at
>>  https://chromium-cq-status.appspot.com/patch-status/1214113010/60001
>>
>>
>> https://codereview.chromium.org/1214113010/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Vitaly Buka (NO REVIEWS), 2015-06-30 22:36:32]

lgtm

[dcheng, 2015-07-01 03:17:40]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-07-01 03:18:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214113010/60001

[commit-bot: I haz the power, 2015-07-01 03:22:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-01 03:23:27]

Patchset 4 (id:??) landed as
https://crrev.com/700bce216cb9399ce306850ee66d3ce5a68c4cfa
Cr-Commit-Position: refs/heads/master@{#336964}