Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1214053003: Convert sbox_integration_tests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
cpu_(ooo_6.6-7.5), Nico
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@1_clang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert sbox_integration_tests to run exclusively on Swarming 0 configs already ran on Swarming 7 used to run locally and were converted: - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert sbox_integration_tests R=cpu@chromium.org,thakis@chromium.org BUG=98637 Committed: https://crrev.com/d6004d9a6aee05042ad2b90e3ee26e50c0e82579 Cr-Commit-Position: refs/heads/master@{#338358}

Patch Set 1 : . #

Patch Set 2 : Include wow_helper only on 32 bits build #

Total comments: 1

Patch Set 3 : Switch from icu.isolate to base.isolate #

Patch Set 4 : Copyright -> 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -6 lines) Patch
M build/gn_migration.gypi View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A + sandbox/sbox_integration_tests.isolate View 1 2 3 2 chunks +11 lines, -6 lines 0 comments Download
M sandbox/win/sandbox_win.gypi View 1 chunk +17 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 5 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
M-A Ruel
5 years, 5 months ago (2015-07-03 20:13:02 UTC) #2
Nico
lgtm https://codereview.chromium.org/1214053003/diff/40001/sandbox/sbox_integration_tests.isolate File sandbox/sbox_integration_tests.isolate (right): https://codereview.chromium.org/1214053003/diff/40001/sandbox/sbox_integration_tests.isolate#newcode29 sandbox/sbox_integration_tests.isolate:29: '../third_party/icu/icu.isolate', base, as in the other cls
5 years, 5 months ago (2015-07-04 00:29:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214053003/60001
5 years, 5 months ago (2015-07-04 02:14:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/75931)
5 years, 5 months ago (2015-07-04 02:20:29 UTC) #8
M-A Ruel
On 2015/07/04 02:20:29, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 5 months ago (2015-07-06 16:03:32 UTC) #10
cpu_(ooo_6.6-7.5)
lgtm
5 years, 5 months ago (2015-07-07 17:52:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214053003/80001
5 years, 5 months ago (2015-07-10 20:09:06 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 5 months ago (2015-07-10 21:17:43 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 21:18:44 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d6004d9a6aee05042ad2b90e3ee26e50c0e82579
Cr-Commit-Position: refs/heads/master@{#338358}

Powered by Google App Engine
This is Rietveld 408576698