Issue 121393002: Revert 241657 "Implement chromium's TLS."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 121393002: Revert 241657 "Implement chromium's TLS." (Closed)

Created:
6 years, 12 months ago by Ken Russell (switch to Gerrit)

Modified:
6 years, 12 months ago

Reviewers:
michaelbai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 241657 "Implement chromium's TLS." Caused intermittent browser process crashes on Linux Debug configurations. See Issue 329747 for details. BUG=329747, 264406 > Implement chromium's TLS. > > Using one system TLS to implement multiple chrome's TLS slots. > > BUG=264406 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241144 > > Review URL: https://codereview.chromium.org/60743004 TBR=michaelbai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242549

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+223 lines, -344 lines)			Patch
M	trunk/src/base/base.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/base/threading/thread_local_storage.h	View	3 chunks	+10 lines, -61 lines	0 comments	Download
D	trunk/src/base/threading/thread_local_storage.cc	View	1 chunk	+0 lines, -250 lines	0 comments	Download
M	trunk/src/base/threading/thread_local_storage_posix.cc	View	1 chunk	+29 lines, -14 lines	0 comments	Download
M	trunk/src/base/threading/thread_local_storage_win.cc	View	2 chunks	+184 lines, -18 lines	0 comments	Download

Total messages: 2 (0 generated)

Ken Russell (switch to Gerrit)

6 years, 12 months ago (2013-12-26 20:05:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r242549.