Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 1213783005: Send HPKP violation reports when a pin check fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index 6186bc2daabf0f0281f3fa34a8fc39e6facec6c6..0c8cc26715051aaa4b760e5f14942e919e250581 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -3092,7 +3092,9 @@ int SSLClientSocketNSS::DoVerifyCertComplete(int result) {
!transport_security_state_->CheckPublicKeyPins(
host_and_port_.host(),
server_cert_verify_result_.is_issued_by_known_root,
- server_cert_verify_result_.public_key_hashes,
+ server_cert_verify_result_.public_key_hashes, host_and_port_.port(),
+ core_->state().server_cert, server_cert_verify_result_.verified_cert,
+ TransportSecurityState::SEND_PUBLIC_KEY_PIN_REPORT,
&pinning_failure_log_)) {
result = ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN;
}

Powered by Google App Engine
This is Rietveld 408576698