Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: net/quic/crypto/proof_verifier_chromium.cc

Issue 1213783005: Send HPKP violation reports when a pin check fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/proof_verifier_chromium.cc
diff --git a/net/quic/crypto/proof_verifier_chromium.cc b/net/quic/crypto/proof_verifier_chromium.cc
index 90543cbbbccf5fcfd3fbb85b8a5eca250acca533..6873158ba9b7342623cd0202ea80e91c6b4bdc86 100644
--- a/net/quic/crypto/proof_verifier_chromium.cc
+++ b/net/quic/crypto/proof_verifier_chromium.cc
@@ -243,13 +243,16 @@ int ProofVerifierChromium::Job::DoVerifyCertComplete(int result) {
const CertVerifyResult& cert_verify_result =
verify_details_->cert_verify_result;
const CertStatus cert_status = cert_verify_result.cert_status;
+ // TODO(estark): replace 0 below with the port that the connection was
+ // made on.
if (transport_security_state_ &&
(result == OK ||
(IsCertificateError(result) && IsCertStatusMinorError(cert_status))) &&
!transport_security_state_->CheckPublicKeyPins(
- hostname_,
- cert_verify_result.is_issued_by_known_root,
- cert_verify_result.public_key_hashes,
+ hostname_, cert_verify_result.is_issued_by_known_root,
+ cert_verify_result.public_key_hashes, 0, cert_,
+ cert_verify_result.verified_cert,
+ TransportSecurityState::SEND_PUBLIC_KEY_PIN_REPORT,
&verify_details_->pinning_failure_log)) {
result = ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN;
}

Powered by Google App Engine
This is Rietveld 408576698