Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1213723006: Drop pattern-related state from GraphicsContext(State) (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
Reviewers:
pdr., f(malita)
CC:
f(malita), blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop pattern-related state from GraphicsContext(State) One trivial use of setFillPattern() in GeneratedImage converted to use an SkPaint directly. As a bonus, this conversion also allows dropping a state-saver. BUG=424655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -69 lines) Patch
M Source/platform/graphics/GeneratedImage.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 2 chunks +0 lines, -28 lines 0 comments Download
M Source/platform/graphics/GraphicsContextState.h View 4 chunks +0 lines, -9 lines 0 comments Download
M Source/platform/graphics/GraphicsContextState.cpp View 5 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 5 months ago (2015-07-01 12:38:35 UTC) #2
f(malita)
w00t! LGTM
5 years, 5 months ago (2015-07-01 12:53:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213723006/1
5 years, 5 months ago (2015-07-01 12:54:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198142
5 years, 5 months ago (2015-07-01 13:28:34 UTC) #6
pdr.
5 years, 5 months ago (2015-07-01 18:06:54 UTC) #7
Message was sent while issue was closed. 
On 2015/07/01 at 13:28:34, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198142

Nice! Posthumous LGTM

Powered by Google App Engine
This is Rietveld 408576698