DescriptionRevert of cc: Measure compositor timing with finer granularity (patchset #8 id:140001 of https://codereview.chromium.org/1192663005/)
Reason for revert:
Flakily fails interactive_ui_tests on Linux Tests (dbg)(1)(32). Link:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/16214
failures:
AppWindowHiddenKeepAliveTest.ShownThenHiddenThenShown
Error:
[1:8:0706/185834:FATAL:compositor_timing_history.cc(104)] Check failed: base::TimeTicks() != begin_main_frame_sent_time_ (0 bogo-microseconds vs. 0 bogo-microseconds)
#0 0x0000ebbb49f4 base::debug::StackTrace::StackTrace()
#1 0x0000ebc17bee logging::LogMessage::~LogMessage()
#2 0x0000eec044b4 cc::CompositorTimingHistory::DidCommit()
#3 0x0000eec043ab cc::CompositorTimingHistory::BeginMainFrameAborted()
#4 0x0000eec0cfa5 cc::Scheduler::BeginMainFrameAborted()
#5 0x0000eed51290 cc::ThreadProxy::BeginMainFrameAbortedOnImplThread()
#6 0x0000eed60235 base::internal::RunnableAdapter\u003C>::Run()
See also:
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)(32)/builds/16214
Original issue's description:
> cc: Measure compositor timing with finer granularity
>
> Measures PrepareTiles, NotifyReadyToActivate, and
> Activation times separately such that idle times
> between actions don't polute results when the
> main thread is in a high latency mode or when
> actions are swap throttled.
>
> Also cleans up how we measure commit times and
> adds DCHECKs to make sure we don't ruin the ordering
> expectations of the CompositorTimingHistory class.
>
> Recording is only enabled while visible and we have
> an output surface in order to avoid cleanup logic
> skewing results.
>
> BUG=406158, 500744
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/65acb94f9258f985cbceedcd3b816cc55cc9522f
> Cr-Commit-Position: refs/heads/master@{#337539}
TBR=mithro@mithis.com,sunnyps@chromium.org,picksi@google.com,brianderson@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=406158, 500744
Committed: https://crrev.com/9c254ff96b53a1b061adb46538478d00d0d24064
Cr-Commit-Position: refs/heads/master@{#337553}
Patch Set 1 #
Created: 5 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 7 (1 generated)
|