Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1213653005: Revert of cc: Measure compositor timing with finer granularity (Closed)

Created:
5 years, 5 months ago by tapted
Modified:
5 years, 5 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@modeTimingHistory3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Measure compositor timing with finer granularity (patchset #8 id:140001 of https://codereview.chromium.org/1192663005/) Reason for revert: Flakily fails interactive_ui_tests on Linux Tests (dbg)(1)(32). Link: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/16214 failures: AppWindowHiddenKeepAliveTest.ShownThenHiddenThenShown Error: [1:8:0706/185834:FATAL:compositor_timing_history.cc(104)] Check failed: base::TimeTicks() != begin_main_frame_sent_time_ (0 bogo-microseconds vs. 0 bogo-microseconds) #0 0x0000ebbb49f4 base::debug::StackTrace::StackTrace() #1 0x0000ebc17bee logging::LogMessage::~LogMessage() #2 0x0000eec044b4 cc::CompositorTimingHistory::DidCommit() #3 0x0000eec043ab cc::CompositorTimingHistory::BeginMainFrameAborted() #4 0x0000eec0cfa5 cc::Scheduler::BeginMainFrameAborted() #5 0x0000eed51290 cc::ThreadProxy::BeginMainFrameAbortedOnImplThread() #6 0x0000eed60235 base::internal::RunnableAdapter\u003C>::Run() See also: https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)(32)/builds/16214 Original issue's description: > cc: Measure compositor timing with finer granularity > > Measures PrepareTiles, NotifyReadyToActivate, and > Activation times separately such that idle times > between actions don't polute results when the > main thread is in a high latency mode or when > actions are swap throttled. > > Also cleans up how we measure commit times and > adds DCHECKs to make sure we don't ruin the ordering > expectations of the CompositorTimingHistory class. > > Recording is only enabled while visible and we have > an output surface in order to avoid cleanup logic > skewing results. > > BUG=406158, 500744 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/65acb94f9258f985cbceedcd3b816cc55cc9522f > Cr-Commit-Position: refs/heads/master@{#337539} TBR=mithro@mithis.com,sunnyps@chromium.org,picksi@google.com,brianderson@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=406158, 500744 Committed: https://crrev.com/9c254ff96b53a1b061adb46538478d00d0d24064 Cr-Commit-Position: refs/heads/master@{#337553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -413 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/scheduler/compositor_timing_history.h View 1 chunk +8 lines, -25 lines 0 comments Download
M cc/scheduler/compositor_timing_history.cc View 4 chunks +34 lines, -125 lines 0 comments Download
D cc/scheduler/compositor_timing_history_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M cc/scheduler/scheduler.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/scheduler/scheduler.cc View 9 chunks +7 lines, -27 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 16 chunks +30 lines, -25 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/scheduler_test_common.h View 2 chunks +7 lines, -13 lines 0 comments Download
M cc/test/scheduler_test_common.cc View 2 chunks +11 lines, -30 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tapted
Created Revert of cc: Measure compositor timing with finer granularity
5 years, 5 months ago (2015-07-07 03:00:28 UTC) #1
tapted
On 2015/07/07 03:00:28, tapted wrote: > Created Revert of cc: Measure compositor timing with finer ...
5 years, 5 months ago (2015-07-07 03:04:12 UTC) #2
tapted
Ah, it's also failing pretty reliably on `Linux Tests (dbg)(1)` Link: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/44393 Reverting (sorry!).
5 years, 5 months ago (2015-07-07 03:10:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213653005/1
5 years, 5 months ago (2015-07-07 03:11:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 03:12:28 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 03:13:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c254ff96b53a1b061adb46538478d00d0d24064
Cr-Commit-Position: refs/heads/master@{#337553}

Powered by Google App Engine
This is Rietveld 408576698